ENG-1328: Port small blueprint based misc settings into props based by sid597 · Pull Request #805 · DiscourseGraphs/discourse-graph

sid597 · 2026-02-20T21:39:24Z

https://www.loom.com/share/612bb20332b1445c977547b14b08b42a

Ported the following:

Queries -> Default filters

Grammar -> Nodes

Nodes -> type -> Format

Nodes -> type -> Attributes

Nodes -> type -> Attributes -> Overlay

Nodes -> type -> Canvas -> Color picker

Nodes -> type -> Canvas -> Display alias

Nodes -> type -> Canvas -> Key image location

Nodes -> type -> Canvas -> Query builder alias

Admin -> (BETA) Suggestive mode enabled

Admin -> Reified relation triples

Summary by CodeRabbit

New Features
- Enhanced feature flag management for Suggestive Mode and Reified relations.
Bug Fixes
- Improved settings persistence and synchronization across discourse node configurations, default filters, and attribute management.
- Fixed color and alias handling in node canvas settings.
Improvements
- Strengthened node type creation and deletion workflows with better data validation and persistence.

linear · 2026-02-20T21:39:26Z

ENG-1328 Port small blueprint based misc settings into props based

supabase · 2026-02-20T21:39:30Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-02-20T21:39:54Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

sid597 · 2026-02-20T21:40:56Z

@coderabbitai full review

coderabbitai · 2026-02-20T21:41:08Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-02-20T21:43:21Z

📝 Walkthrough

Walkthrough

This PR adds centralized settings persistence across discourse node configuration and admin panels by introducing calls to setFeatureFlag, setPersonalSetting, and setDiscourseNodeSetting throughout settings components. It refactors component signatures to accept nodeType and onSync callbacks, replaces some inline UI with reusable panel components, and introduces strong typing for discourse relations.

Changes

Cohort / File(s)	Summary
Feature Flag & Personal Settings `apps/roam/src/components/settings/AdminPanel.tsx`, `apps/roam/src/components/settings/DefaultFilters.tsx`	AdminPanel now calls `setFeatureFlag` when toggling Suggestive Mode and Reified relations features. DefaultFilters refactored to use `setPersonalSetting` alongside `extensionAPI.settings.set` for dual persistence of default filters.
Discourse Node Settings Sync `apps/roam/src/components/settings/DiscourseNodeAttributes.tsx`, `apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx`, `apps/roam/src/components/settings/DiscourseNodeConfigPanel.tsx`, `apps/roam/src/components/settings/NodeConfig.tsx`	Multiple components now integrate `setDiscourseNodeSetting` to persist attribute edits, color changes, alias updates, and canvas settings. DiscourseNodeConfigPanel introduces strong typing for `DiscourseRelation`, calculates shortcut/format from labels, and handles deletion of affected relations. DiscourseNodeAttributes signature expanded to include `nodeType` parameter. NodeConfig refactors `useDebouncedRoamUpdater` signature, integrates `DiscourseNodeSelectPanel`, and adds `onSync` callback wiring.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

ENG-1187: Prod: Implement get and set for block prop based settings #669: Implements the setFeatureFlag, setPersonalSetting, and setDiscourseNodeSetting utilities that this PR depends on and uses throughout the settings components.
Roam: When a user deletes a node also delete all the corresponding relations to the node - ENG-26 #149: Directly modifies DiscourseNodeConfigPanel to identify and delete affected relations when a discourse node type is removed, sharing core logic changes.
ENG-1112: add suggestive mode flag and settings to admin panel #589: Directly modifies AdminPanel.tsx to manage the Suggestive Mode feature flag state and UI toggles.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective of the changeset: porting blueprint-based miscellaneous settings into a props-based implementation across multiple settings files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sid597 · 2026-02-20T21:44:45Z

@coderabbitai full review

coderabbitai · 2026-02-20T21:44:58Z

✅ Actions performed

Full review triggered.

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional findings.

These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings

specification, config panel) The initial recovery commit claimed to include these but only contained Chain 2 (#793, #794, #805, #804). Chain 1 lives on separate branches that weren't in the merge source. Applied using `gh pr diff` for each PR in order (#764 → #765 → #769). init.ts required manual merge — #765 and #769 both modified it from the same base. Kept #765's safeParse checks inside #769's restructured initializeSettingsBlockProps. - #764 ENG-1280: Port query builder and editor component for block props - #765 ENG-1291: Port discourse node specification - #769 ENG-1290: Port discourse node config panel

…#826) * Land orphaned Graphite stack PRs (#764, #765, #769, #793, #794, #805) These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings * Add #804 ENG-1217: Port section component in left sidebar * Add #764, #765, #769 (Chain 1 orphaned PRs: query builder, specification, config panel) The initial recovery commit claimed to include these but only contained Chain 2 (#793, #794, #805, #804). Chain 1 lives on separate branches that weren't in the merge source. Applied using `gh pr diff` for each PR in order (#764 → #765 → #769). init.ts required manual merge — #765 and #769 both modified it from the same base. Kept #765's safeParse checks inside #769's restructured initializeSettingsBlockProps. - #764 ENG-1280: Port query builder and editor component for block props - #765 ENG-1291: Port discourse node specification - #769 ENG-1290: Port discourse node config panel * fix lint * prettier

These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings

sid597 mentioned this pull request Feb 20, 2026

dual write page group to block props #795

Closed

sid597 marked this pull request as ready for review February 20, 2026 21:40

This comment was marked as resolved.

Sign in to view

devin-ai-integration bot reviewed Feb 20, 2026

View reviewed changes

sid597 changed the base branch from eng-1281-port-discourse-node-block-panel to graphite-base/805 February 23, 2026 05:10

sid597 force-pushed the graphite-base/805 branch from 59ba6a6 to 1b467b4 Compare February 23, 2026 10:26

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from d88de41 to 1d2ba62 Compare February 23, 2026 10:26

sid597 changed the base branch from graphite-base/805 to eng-1281-port-discourse-node-block-panel February 23, 2026 10:27

sid597 mentioned this pull request Feb 23, 2026

ENG-1217: Port section component in left sidebar #804

Merged

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from 1d2ba62 to 4634da5 Compare February 23, 2026 10:40

sid597 force-pushed the eng-1281-port-discourse-node-block-panel branch from 1b467b4 to 2d39338 Compare February 23, 2026 10:40

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from 4634da5 to 1b440fb Compare February 23, 2026 13:51

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from 84b5f88 to eb2aaa7 Compare February 23, 2026 16:40

sid597 force-pushed the graphite-base/805 branch from cd7e227 to 6e6165a Compare February 23, 2026 16:40

sid597 changed the base branch from graphite-base/805 to eng-1281-port-discourse-node-block-panel February 23, 2026 16:40

sid597 changed the base branch from eng-1281-port-discourse-node-block-panel to graphite-base/805 February 23, 2026 17:52

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from eb2aaa7 to 26619e2 Compare February 23, 2026 17:53

sid597 mentioned this pull request Feb 24, 2026

ENG-1467: Port global setting consumer reads (→ getGlobalSetting) #821

Closed

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from 26619e2 to ef60df6 Compare February 24, 2026 05:46

sid597 force-pushed the graphite-base/805 branch from 8ade9cd to 8feebf0 Compare February 24, 2026 05:46

sid597 changed the base branch from graphite-base/805 to eng-1438-keyboard-quick-shortcut-keystriggers February 24, 2026 05:46

sid597 added 9 commits February 24, 2026 11:18

ENG-1328: Port small blueprint based misc settings into props based

9046f4a

attributes -> overlay

fb51d4a

attributes label

1c6b6aa

default filters

9a513d0

node config

dab9e65

fix lint

26999de

prettier

c1f0a1c

port format panel

d29036a

prettier

5d03b39

sid597 force-pushed the eng-1438-keyboard-quick-shortcut-keystriggers branch from 8feebf0 to 1ded5d4 Compare February 24, 2026 05:48

sid597 force-pushed the eng-1328-port-small-blueprint-based-misc-settings-into-props-based branch from ef60df6 to 5d03b39 Compare February 24, 2026 05:48

mdroidian approved these changes Feb 24, 2026

View reviewed changes

sid597 merged commit 5761e62 into eng-1438-keyboard-quick-shortcut-keystriggers Feb 24, 2026
13 checks passed

sid597 mentioned this pull request Feb 24, 2026

ENG-1468: Port node and relations tree based consumers #822

Closed

This was referenced Feb 24, 2026

ENG-1468: Port node and relations tree based consumers #825

Open

Eng-1473 port non boolean personal setting consumers #823

Open

sid597 mentioned this pull request Feb 24, 2026

Land orphaned Graphite stack PRs (#764, #765, #769, #793, #794, #805) #826

Merged

77 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENG-1328: Port small blueprint based misc settings into props based#805

ENG-1328: Port small blueprint based misc settings into props based#805
sid597 merged 9 commits intoeng-1438-keyboard-quick-shortcut-keystriggersfrom
eng-1328-port-small-blueprint-based-misc-settings-into-props-based

sid597 commented Feb 20, 2026 •

edited

Loading

Uh oh!

linear bot commented Feb 20, 2026

Uh oh!

supabase bot commented Feb 20, 2026

Uh oh!

sid597 commented Feb 20, 2026 •

edited

Loading

Uh oh!

sid597 commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

sid597 commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sid597 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Feb 20, 2026

Uh oh!

supabase bot commented Feb 20, 2026

Uh oh!

sid597 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sid597 commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

sid597 commented Feb 20, 2026

Uh oh!

coderabbitai bot commented Feb 20, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Feb 20, 2026 •

edited

Loading

sid597 commented Feb 20, 2026 •

edited

Loading

coderabbitai bot commented Feb 20, 2026 •

edited

Loading