ENG-1468: Port node and relations tree based consumers

[sid597]

https://www.loom.com/share/4f94dbd77bd44d178a5b6e49d4b7cfbc

---

Summary by CodeRabbit

• Refactor
  • Improved settings and configuration retrieval across the application by migrating to dedicated accessor functions for more reliable and centralized settings management.
  • Enhanced feature flag handling for the Suggestive Mode configuration.
  • Streamlined node attribute and relation settings access patterns.

[linear]

ENG-1468 Port node and relations tree-based consumers (→ getDiscourseNodeSetting)

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request migrates discourse node and settings configuration from tree-based retrieval (using Roam subtree navigation) to centralized accessor functions. Components that previously used getBasicTreeByParentUid and getSettingValueFromTree now use getDiscourseNodeSetting, getGlobalSetting, and getFeatureFlag to fetch configuration values.

Changes

Cohort / File(s)	Summary
Settings Accessor Migration apps/roam/src/components/DiscourseContextOverlay.tsx, apps/roam/src/components/settings/DiscourseNodeSpecification.tsx, apps/roam/src/components/settings/NodeConfig.tsx, apps/roam/src/utils/deriveDiscourseNodeAttribute.ts	Replaced tree-based setting retrieval with direct calls to getDiscourseNodeSetting for accessing node attributes, overlay, specification.enabled, and color settings. Dependency arrays updated to reflect new data sources.
Canvas Settings Migration apps/roam/src/components/settings/DiscourseNodeCanvasSettings.tsx	Migrated color, alias, query-builder-alias, key-image, and key-image-option settings from tree-based lookup to getDiscourseNodeSetting. Includes unresolved merge conflict markers in imports and state initialization sections.
Relation Configuration apps/roam/src/components/settings/DiscourseRelationConfigPanel.tsx	Replaced getSettingValueFromTree with getGlobalSetting for relation config values (source, destination, complement). Added getFeatureFlag import for future use.
Feature Flag Integration apps/roam/src/index.ts	Changed "Suggestive Mode Enabled" flag resolution from tree-based setting lookup to getFeatureFlag("Suggestive mode enabled") to control initializeSupabaseSync() initialization path.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• ENG-1291: Port discourse node specification #765: Directly related—both PRs migrate specification.enabled from subtree/UID-based storage to boolean and switch components to use centralized getDiscourseNodeSetting accessors.
• ENG-1328: Port small blueprint based misc settings into props based #805: Related—both PRs replace tree-based setting reads with centralized accessors (getDiscourseNodeSetting, getGlobalSetting, getFeatureFlag) across the same components.
• ENG-846 - Add Colors to Nodes in settings #699: Related—both PRs modify DiscourseNodeCanvasSettings to source node color through centralized accessors rather than tree navigation.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'ENG-1468: Port node and relations tree based consumers' directly describes the main objective of the PR: migrating tree-based setting retrieval to new accessor-based patterns across multiple components.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}