Eng-1473 port non boolean personal setting consumers

[sid597]

https://www.loom.com/share/4354dc62c72d4050b06876051451169a

---

Summary by CodeRabbit

• Refactor
  • Settings for keyboard shortcuts, node menu triggers, search triggers, filters, and query pages are now stored as personal preferences instead of global settings.

[linear]

ENG-1473 Port non-boolean personal setting consumers

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR migrates settings access across multiple components and utilities from direct extensionAPI.settings calls to a centralized getPersonalSetting/setPersonalSetting accessor pattern, affecting keyboard trigger reading, default filter persistence, and query page configuration.

Changes

Cohort / File(s)	Summary
Keyboard Shortcut Triggers apps/roam/src/components/DiscourseNodeMenu.tsx, apps/roam/src/components/DiscourseNodeSearchMenu.tsx, apps/roam/src/components/settings/KeyboardShortcutInput.tsx, apps/roam/src/utils/initializeObserversAndListeners.ts	Replaces direct extensionAPI.settings access with getPersonalSetting calls for personal-node-menu-trigger and node-search-trigger key combos, with appropriate fallbacks and nullish coalescing guards.
Query and Page Settings apps/roam/src/components/settings/QueryPagesPanel.tsx, apps/roam/src/components/settings/QuerySettings.tsx, apps/roam/src/utils/setQueryPages.ts	Refactors query page retrieval to use getPersonalSetting with simplified type handling; introduces persistQueryPages helper for dual writing to both personal and extension settings; removes redundant initialValue props from QuerySettings.
Default Filters Persistence apps/roam/src/components/settings/DefaultFilters.tsx	Migrates default-filters reading to getPersonalSetting and adds dual persistence to both personal and extension settings; updates effect dependencies to include extensionAPI.settings changes.
Settings Utilities apps/roam/src/components/settings/utils/accessors.ts	Minor refactor to compute path key once before map lookup, preserving existing behavior and error handling.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• ENG-1190 Replace existing roam-js components with blockProp based ones #689: Both PRs migrate settings access to use personal/global getter/setter accessor pattern instead of direct extensionAPI.settings calls.
• ENG-1328: Port small blueprint based misc settings into props based #805: Both PRs add personal-setting persistence to DefaultFilters using getPersonalSetting/setPersonalSetting accessors.
• ENG-1438: Port Keyboard shortcut keys/triggers settings #794: Both PRs refactor keyboard-shortcut trigger handling in DiscourseNodeMenu, DiscourseNodeSearchMenu, and related components to use personal setting accessors.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Eng-1473 port non boolean personal setting consumers' directly and clearly describes the main objective of the changeset: migrating non-boolean personal setting consumers to use the new accessor-backed pattern.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Warning

Rate limit exceeded

@sid597 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 17 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9d90ba0 and 6f65c7c.

📒 Files selected for processing (9)

• apps/roam/src/components/DiscourseNodeMenu.tsx
• apps/roam/src/components/DiscourseNodeSearchMenu.tsx
• apps/roam/src/components/settings/DefaultFilters.tsx
• apps/roam/src/components/settings/KeyboardShortcutInput.tsx
• apps/roam/src/components/settings/QueryPagesPanel.tsx
• apps/roam/src/components/settings/QuerySettings.tsx
• apps/roam/src/components/settings/utils/accessors.ts
• apps/roam/src/utils/initializeObserversAndListeners.ts
• apps/roam/src/utils/setQueryPages.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}