ENG-1465: Add "Use new settings store" feature flag

[sid597]

https://www.loom.com/share/ada47787b17b48c78d46ecbf1e44c0c6

add caller

---

Summary by CodeRabbit

• New Features
  • Added "Use new settings store" feature flag to the admin panel. When enabled, the settings system reads from block properties, surfacing any dual-write gaps during development.
  • Implemented change tracking infrastructure for the settings system.

[linear]

ENG-1465 Add "Enable dual read" feature flag with reactive accessor routing

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1468: Port node and relations tree based consumers #822
• ENG-1467: Port global setting consumer reads (→ getGlobalSetting) #821
• ENG-1473: Port non-boolean personal setting consumers #818
• ENG-1456: Migrate personal boolean flag consumers (getSetting → getPersonalSetting) #814
• ENG-1472: Refactor BlockPropSettingPanels to add accessor-backed default reads #813
• ENG-1455: Dual-read from old-system settings and from blockprops #812
• ENG-1465: Add "Use new settings store" feature flag  #811 👈 (View in Graphite)
• ENG-1217: Port section component in left sidebar #804
• ENG-1328: Port small blueprint based misc settings into props based #805
• eng-1438-keyboard-quick-shortcut-keystriggers

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR introduces a new feature flag "Use new settings store" that enables reading accessor getters from block props instead of the old system. The flag is added to the schema, exposed in the admin UI, and the initialization flow is extended to set up pull-watchers on the settings page.

Changes

Cohort / File(s)	Summary
Feature Flag Schema apps/roam/src/components/settings/utils/zodSchema.ts, apps/roam/src/components/settings/utils/zodSchema.example.ts	Added a new boolean "Use new settings store" field with default false to FeatureFlagsSchema and example feature flag objects.
Admin UI & Accessors apps/roam/src/components/settings/AdminPanel.tsx, apps/roam/src/components/settings/utils/accessors.ts	Rendered a FeatureFlagPanel in AdminPanel for the new "Use new settings store" flag and added a helper function isNewSettingsStoreEnabled() that wraps the feature flag accessor.
Initialization Setup apps/roam/src/index.ts	Modified initSchema() to return blockUids and integrated setupPullWatchOnSettingsPage call with cleanup routine registration on unload.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ENG-1190 Replace existing roam-js components with blockProp based ones #689: Introduces the FeatureFlagPanel component that is directly used by this PR's AdminPanel updates.
• ENG-1188: prod: pull watchers for prop based settings #682: Implements setupPullWatchOnSettingsPage utility that is imported and called in this PR's index.ts initialization flow.
• ENG-1014 Add Admin Feature Flag for “Reified Relation Triples” Flow #532: Restructures AdminPanel with tabs to expose admin feature-flag controls, directly related to the feature flag UI integration in this PR.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically describes the main change: adding a new feature flag called 'Use new settings store' which is the core modification across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

🧹 Nitpick comments (2)

apps/roam/src/components/settings/utils/accessors.ts (1)

288-291: Optional: simplify to expression body.

The function body is a single return statement; an expression arrow matches the style of getFeatureFlag directly above it.

♻️ Proposed simplification

-export const isNewSettingsStoreEnabled = (): boolean => {
-  return getFeatureFlag("Use new settings store");
-};
+export const isNewSettingsStoreEnabled = (): boolean =>
+  getFeatureFlag("Use new settings store");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/roam/src/components/settings/utils/accessors.ts` around lines 288 - 291,
The function isNewSettingsStoreEnabled has a single return statement; simplify
it to an expression-bodied arrow to match the surrounding style (like
getFeatureFlag) by replacing the block body with a concise expression returning
getFeatureFlag("Use new settings store"); keep the same function name
isNewSettingsStoreEnabled and behavior.

apps/roam/src/components/settings/AdminPanel.tsx (1)

468-473: getFeatureFlag called at render time causes unnecessary Roam API calls; confirm need for memoization.

getFeatureFlag("Use new settings store") is evaluated on every re-render of FeatureFlagsTab (triggered by state changes like isAlertOpen, isInstructionOpen), which invokes getBlockUidByTextOnPage and getBlockProps each time. While BaseFlagPanel correctly uses useState(() => initialValue ?? false) to initialize state only once, re-computing the initial value on every parent render is wasteful and causes unnecessary Roam API calls.

The RoamBlockSyncProps fields (parentUid, uid, order) are all optional and do not need to be passed here.

♻️ Optional refactor to memoize the feature flag value

 const FeatureFlagsTab = (): React.ReactElement => {
   ...
+  const [isNewSettingsStoreEnabled] = useState(() =>
+    getFeatureFlag("Use new settings store"),
+  );
   ...
       <FeatureFlagPanel
         title="Use new settings store"
         description="When enabled, accessor getters read from block props instead of the old system. Surfaces dual-write gaps during development."
         featureKey="Use new settings store"
-        initialValue={getFeatureFlag("Use new settings store")}
+        initialValue={isNewSettingsStoreEnabled}
       />

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/roam/src/components/settings/AdminPanel.tsx` around lines 468 - 473, The
call to getFeatureFlag("Use new settings store") in FeatureFlagsTab causes Roam
API calls on every render; change FeatureFlagPanel usage so the initialValue is
memoized or computed once (e.g., compute value with useMemo or initialize a
local state once) and pass that memoized/initialized boolean to FeatureFlagPanel
instead of calling getFeatureFlag directly during render. Locate FeatureFlagsTab
and replace the direct getFeatureFlag(...) call with a stable value (memoized or
via useState(() => getFeatureFlag(...))) so BaseFlagPanel’s useState(() =>
initialValue ?? false) only runs once; also remove the unnecessary optional
RoamBlockSyncProps (parentUid, uid, order) from the props passed to
FeatureFlagPanel.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/roam/src/components/settings/AdminPanel.tsx`:
- Around line 468-473: The call to getFeatureFlag("Use new settings store") in
FeatureFlagsTab causes Roam API calls on every render; change FeatureFlagPanel
usage so the initialValue is memoized or computed once (e.g., compute value with
useMemo or initialize a local state once) and pass that memoized/initialized
boolean to FeatureFlagPanel instead of calling getFeatureFlag directly during
render. Locate FeatureFlagsTab and replace the direct getFeatureFlag(...) call
with a stable value (memoized or via useState(() => getFeatureFlag(...))) so
BaseFlagPanel’s useState(() => initialValue ?? false) only runs once; also
remove the unnecessary optional RoamBlockSyncProps (parentUid, uid, order) from
the props passed to FeatureFlagPanel.

In `@apps/roam/src/components/settings/utils/accessors.ts`:
- Around line 288-291: The function isNewSettingsStoreEnabled has a single
return statement; simplify it to an expression-bodied arrow to match the
surrounding style (like getFeatureFlag) by replacing the block body with a
concise expression returning getFeatureFlag("Use new settings store"); keep the
same function name isNewSettingsStoreEnabled and behavior.

---

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a44f91 and 2b16770.

📒 Files selected for processing (5)

• apps/roam/src/components/settings/AdminPanel.tsx
• apps/roam/src/components/settings/utils/accessors.ts
• apps/roam/src/components/settings/utils/zodSchema.example.ts
• apps/roam/src/components/settings/utils/zodSchema.ts
• apps/roam/src/index.ts