ENG-1440: Port page groups settings in suggestive mode by sid597 · Pull Request #793 · DiscourseGraphs/discourse-graph

sid597 · 2026-02-17T12:28:16Z

https://www.loom.com/share/dcdbb3b9441145fe94bf152f84fff80b

Summary by CodeRabbit

Bug Fixes
- Page group persistence improved. Groups now properly synchronize with global settings whenever changes occur—when groups are created, deleted, or when pages are added to or removed from groups. Changes are immediately saved.
New Features
- Schema initialization now runs automatically on extension startup, ensuring the extension is properly configured without requiring manual intervention.

linear · 2026-02-17T12:28:19Z

ENG-1440 Port page groups settings in suggestive mode

ENG-1217 Section components in Left sidebar

supabase · 2026-02-17T12:28:25Z

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

sid597 · 2026-02-17T12:28:29Z

@coderabbitai full review

coderabbitai · 2026-02-17T12:28:38Z

✅ Actions performed

Full review triggered.

coderabbitai · 2026-02-17T12:30:58Z

Caution

Review failed

An error occurred during the review process. Please try again later.

📝 Walkthrough

Walkthrough

This change introduces schema initialization during extension load and synchronizes PageGroup state changes with global settings storage through a new syncPageGroupsToBlockProps helper function that persists local group modifications.

Changes

Cohort / File(s)	Summary
Settings State Synchronization `apps/roam/src/components/settings/PageGroupPanel.tsx`	Adds `syncPageGroupsToBlockProps()` helper to persist PageGroup changes to global settings and updates all group modification handlers (create, remove, add page, remove page) to call this sync function after state updates.
Extension Initialization `apps/roam/src/index.ts`	Imports and invokes `initSchema()` during extension initialization, placing the call before returning the public interface to ensure schema setup runs on load.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

ENG-1190 Replace existing roam-js components with blockProp based ones #689 — Introduces block-prop-based getters and setters for Roam settings, providing the underlying mechanism that this PR leverages for setGlobalSetting.
ENG-1345: Modify existing RoamJS component onChange to also change props #745 — Extends settings UI panels with block-sync behavior and properties, complementing the state synchronization pattern implemented here.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The PR title references 'ENG-1440' but the PR objectives mention 'ENG-1217', creating a mismatch. Additionally, the title 'Port page groups settings in suggestive mode' is overly broad and vague—the actual changes focus on synchronizing page group settings to block properties (dual-write implementation), which is more specific than the generic 'port' language suggests.	Clarify the ticket reference (ENG-1440 vs ENG-1217) and consider a more specific title that captures the dual-write synchronization of page groups to block properties, such as 'Sync page groups to block properties'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

sid597 · 2026-02-17T12:51:33Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

ENG-1438: Port Keyboard shortcut keys/triggers settings #794
ENG-1440: Port page groups settings in suggestive mode #793 👈 (View in Graphite)
ENG-1281: Port discourse node block panel #784 : 1 other dependent PR (#795 )
ENG-1290: Port discourse node config panel #769
ENG-1291: Port discourse node specification #765
ENG-1280: Port Discourse node: Query builder and editor component for block props #764
ENG-1225: Discourse node migration simple settings #696 : 1 other dependent PR (#697 )
ENG-1273: Migrate small personal settings #691
ENG-1272 Migrate all small global settings components #688 : 1 other dependent PR (#690 )
ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#684 )
ENG-1190 Replace existing roam-js components with blockProp based ones #689
ENG-1188: prod: pull watchers for prop based settings #682
ENG-1187: Prod: Implement get and set for block prop based settings #669
ENG-1189: Prod: Init block prop based schema #666
ENG-1330: zod schema for discourse relations #719
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

mdroidian

👍

Couple of Devin comments worth looking into, but not blocking.

apps/roam/src/index.ts

These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings

specification, config panel) The initial recovery commit claimed to include these but only contained Chain 2 (#793, #794, #805, #804). Chain 1 lives on separate branches that weren't in the merge source. Applied using `gh pr diff` for each PR in order (#764 → #765 → #769). init.ts required manual merge — #765 and #769 both modified it from the same base. Kept #765's safeParse checks inside #769's restructured initializeSettingsBlockProps. - #764 ENG-1280: Port query builder and editor component for block props - #765 ENG-1291: Port discourse node specification - #769 ENG-1290: Port discourse node config panel

…#826) * Land orphaned Graphite stack PRs (#764, #765, #769, #793, #794, #805) These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings * Add #804 ENG-1217: Port section component in left sidebar * Add #764, #765, #769 (Chain 1 orphaned PRs: query builder, specification, config panel) The initial recovery commit claimed to include these but only contained Chain 2 (#793, #794, #805, #804). Chain 1 lives on separate branches that weren't in the merge source. Applied using `gh pr diff` for each PR in order (#764 → #765 → #769). init.ts required manual merge — #765 and #769 both modified it from the same base. Kept #765's safeParse checks inside #769's restructured initializeSettingsBlockProps. - #764 ENG-1280: Port query builder and editor component for block props - #765 ENG-1291: Port discourse node specification - #769 ENG-1290: Port discourse node config panel * fix lint * prettier

These PRs were squash-merged into parent branches instead of main due to a Graphite stack merge race condition. Their changes never landed on main despite showing as merged in Graphite. Includes: - #764 ENG-1280: Port query builder/editor for block props - #765 ENG-1291: Port discourse node specification (dual-write) - #769 ENG-1290: Port discourse node config panel - #793 ENG-1440: Port page groups settings in suggestive mode - #794 ENG-1438: Port keyboard shortcut keys/triggers - #805 ENG-1328: Port small blueprint misc settings

This comment was marked as resolved.

Sign in to view

devin-ai-integration bot reviewed Feb 17, 2026

View reviewed changes

sid597 requested review from mdroidian and removed request for mdroidian February 17, 2026 12:41

sid597 changed the base branch from main to graphite-base/793 February 17, 2026 12:51

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch from 5f263ce to 6ef48f7 Compare February 17, 2026 12:51

sid597 force-pushed the graphite-base/793 branch from 52389ff to 6baa3dd Compare February 17, 2026 12:51

sid597 changed the base branch from graphite-base/793 to eng-1281-port-discourse-node-block-panel February 17, 2026 12:51

This was referenced Feb 17, 2026

ENG-1280: Port Discourse node: Query builder and editor component for block props #764

Merged

ENG-1291: Port discourse node specification #765

Merged

ENG-1290: Port discourse node config panel #769

Merged

sid597 mentioned this pull request Feb 17, 2026

ENG-1281: Port discourse node block panel #784

Merged

This comment was marked as resolved.

Sign in to view

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch from 6ef48f7 to 5ccc071 Compare February 17, 2026 12:56

sid597 requested a review from mdroidian February 17, 2026 13:00

sid597 mentioned this pull request Feb 17, 2026

ENG-1438: Port Keyboard shortcut keys/triggers settings #794

Merged

sid597 changed the title ~~ENG-1217: Port page groups settings in suggestive mode~~ ENG-1440: Port page groups settings in suggestive mode Feb 17, 2026

sid597 mentioned this pull request Feb 17, 2026

dual write page group to block props #795

Closed

sid597 changed the base branch from eng-1281-port-discourse-node-block-panel to graphite-base/793 February 17, 2026 15:07

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch from d1168f9 to ac0a069 Compare February 17, 2026 15:16

sid597 force-pushed the graphite-base/793 branch from 6baa3dd to 05303b8 Compare February 17, 2026 15:16

sid597 changed the base branch from graphite-base/793 to eng-1281-port-discourse-node-block-panel February 17, 2026 15:17

This comment was marked as resolved.

Sign in to view

sid597 force-pushed the eng-1281-port-discourse-node-block-panel branch from 05303b8 to 7e3799e Compare February 17, 2026 15:37

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch from ac0a069 to 547a44d Compare February 17, 2026 15:37

sid597 force-pushed the eng-1281-port-discourse-node-block-panel branch from 7e3799e to f1d6f92 Compare February 17, 2026 15:47

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch 2 times, most recently from 01ef4ec to 8c85845 Compare February 17, 2026 16:04

sid597 force-pushed the eng-1281-port-discourse-node-block-panel branch from f1d6f92 to 59ba6a6 Compare February 17, 2026 16:04

This comment was marked as resolved.

Sign in to view

mdroidian approved these changes Feb 18, 2026

View reviewed changes

apps/roam/src/index.ts Show resolved Hide resolved

sid597 added 4 commits February 23, 2026 10:31

dual write page group to block props

d2ed9b5

fix after restack

0669b38

comment out discoursenode initialization from init.ts

2eecfac

restack

c4f0860

sid597 force-pushed the eng-1217-page-groups-left-sidebar branch from d9a05d4 to c4f0860 Compare February 23, 2026 05:11

sid597 force-pushed the eng-1281-port-discourse-node-block-panel branch from 59ba6a6 to 3c00e79 Compare February 23, 2026 05:11

prettier

55037dd

sid597 merged commit fad1443 into eng-1281-port-discourse-node-block-panel Feb 23, 2026
9 of 10 checks passed

sid597 mentioned this pull request Feb 23, 2026

ENG-1217: Port section component in left sidebar #804

Merged

sid597 deleted the eng-1217-page-groups-left-sidebar branch February 23, 2026 10:41

sid597 restored the eng-1217-page-groups-left-sidebar branch February 23, 2026 11:03

sid597 mentioned this pull request Feb 23, 2026

ENG-1473: Port non-boolean personal setting consumers #818

Closed

sid597 mentioned this pull request Feb 24, 2026

Land orphaned Graphite stack PRs (#764, #765, #769, #793, #794, #805) #826

Merged

77 tasks

Conversation

sid597 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

linear bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

supabase bot commented Feb 17, 2026

Uh oh!

sid597 commented Feb 17, 2026

Uh oh!

coderabbitai bot commented Feb 17, 2026

Uh oh!

coderabbitai bot commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

❌ Failed checks (1 inconclusive)

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

sid597 commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

mdroidian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sid597 commented Feb 17, 2026 •

edited

Loading

linear bot commented Feb 17, 2026 •

edited

Loading

coderabbitai bot commented Feb 17, 2026 •

edited

Loading

sid597 commented Feb 17, 2026 •

edited

Loading

mdroidian left a comment •

edited

Loading