fix: Fix Enter key blocked after dismissing empty suggestion popup#1471
Merged
charlesvien merged 2 commits intomainfrom Apr 3, 2026
Merged
Conversation
This was referenced Apr 2, 2026
Member
Author
This was referenced Apr 2, 2026
a92e5cb to
f8e0608
Compare
0851b92 to
d21da9b
Compare
f8e0608 to
b6525f2
Compare
d21da9b to
acf7ecf
Compare
b6525f2 to
b450f66
Compare
25abfee to
8236097
Compare
121d6bb to
ad9e547
Compare
8236097 to
71fc7d5
Compare
adboio
approved these changes
Apr 3, 2026
ad9e547 to
ed7b176
Compare
71fc7d5 to
1242182
Compare
Member
Author
Merge activity
|
ed7b176 to
4f832dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Pressing Escape on a suggestion popup with no results hides it visually but leaves the Tippy DOM node mounted, causing the Enter-to-submit handler to think a suggestion is still active.
Changes
How did you test this?
Manually