Skip to content

fix: Open active file in external app instead of repo directory#1470

Merged
charlesvien merged 2 commits intomainfrom
04-02-active_file_external_app_fix
Apr 3, 2026
Merged

fix: Open active file in external app instead of repo directory#1470
charlesvien merged 2 commits intomainfrom
04-02-active_file_external_app_fix

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 2, 2026

Problem

Clicking "Open in [app]" always opened the repo root directory, even when a specific file was active in the editor.

Changes

  1. Derive active file path from panel layout store in TaskDetail
  2. Join relative path with repo path as the external app target, fall back to repo directory
  3. Add fixed overlay to prevent drag-through when dropdown menu is open
  4. Fix dead diff type check and normalize path joining

How did you test this?

Manually

@charlesvien charlesvien changed the title Open active file in external app instead of repo directory fix: Open active file in external app instead of repo directory Apr 2, 2026
@charlesvien charlesvien marked this pull request as ready for review April 2, 2026 22:21
@charlesvien charlesvien force-pushed the 04-02-permissions_ui_nits branch from d32c95f to c9f077b Compare April 2, 2026 22:38
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch from 0851b92 to d21da9b Compare April 2, 2026 22:38
@charlesvien charlesvien force-pushed the 04-02-permissions_ui_nits branch from c9f077b to fdc1564 Compare April 2, 2026 22:55
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch 2 times, most recently from acf7ecf to 25abfee Compare April 2, 2026 22:56
@charlesvien charlesvien force-pushed the 04-02-permissions_ui_nits branch 2 times, most recently from e002336 to 2a03b44 Compare April 2, 2026 22:57
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch from 25abfee to 8236097 Compare April 2, 2026 22:57
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch from 8236097 to 71fc7d5 Compare April 2, 2026 23:33
@charlesvien charlesvien force-pushed the 04-02-permissions_ui_nits branch from 9301abf to 5cf1b30 Compare April 3, 2026 00:56
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch from 71fc7d5 to 1242182 Compare April 3, 2026 00:56
Copy link
Copy Markdown
Member Author

charlesvien commented Apr 3, 2026

Merge activity

  • Apr 3, 1:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 3, 1:13 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 3, 1:18 AM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 04-02-permissions_ui_nits to graphite-base/1470 April 3, 2026 01:06
@charlesvien charlesvien changed the base branch from graphite-base/1470 to main April 3, 2026 01:11
@charlesvien charlesvien force-pushed the 04-02-active_file_external_app_fix branch from 1242182 to be9ee22 Compare April 3, 2026 01:12
@charlesvien charlesvien merged commit 1fd277a into main Apr 3, 2026
16 checks passed
@charlesvien charlesvien deleted the 04-02-active_file_external_app_fix branch April 3, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants