Fix dead diff type check, normalize path join, reorder hooks

Author: charlesvien

apps/code/src/renderer/features/task-detail/components/ExternalAppsOpener.tsx

@@ -20,6 +20,7 @@ export function ExternalAppsOpener({
   label = "Open",
 }: ExternalAppsOpenerProps) {
   const { detectedApps, defaultApp, isLoading } = useExternalApps();
+  const [dropdownOpen, setDropdownOpen] = useState(false);
 
   const handleOpenDefault = useCallback(async () => {
     if (!defaultApp || !targetPath) return;
@@ -74,8 +75,6 @@ export function ExternalAppsOpener({
     [handleCopyPath],
   );
 
-  const [dropdownOpen, setDropdownOpen] = useState(false);
-
   if (!targetPath) {
     return null;
   }

apps/code/src/renderer/features/task-detail/components/TaskDetail.tsx

@@ -46,15 +46,15 @@ export function TaskDetail({ task: initialTask }: TaskDetailProps) {
     if (!panel) return null;
 
     const parsed = parseTabId(panel.content.activeTabId);
-    if (parsed.type === "file" || parsed.type === "diff") {
+    if (parsed.type === "file") {
       return parsed.value;
     }
     return null;
   });
 
   const openTargetPath =
     activeRelativePath && effectiveRepoPath
-      ? `${effectiveRepoPath}/${activeRelativePath}`
+      ? [effectiveRepoPath, activeRelativePath].join("/").replace(/\/+/g, "/")
       : effectiveRepoPath;
 
   const [filePickerOpen, setFilePickerOpen] = useState(false);