Skip to content

fix: Show parent directory in file mention chips#1472

Open
charlesvien wants to merge 5 commits intomainfrom
04-02-file_chip_improvements
Open

fix: Show parent directory in file mention chips#1472
charlesvien wants to merge 5 commits intomainfrom
04-02-file_chip_improvements

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented Apr 2, 2026

Problem

File mention chips only show the filename, making it hard to distinguish between files with the same name in different directories. Absolute file paths pasted into @ mentions aren't recognized at all.

Changes

  1. Show parent directory prefix in file mention chip labels (e.g. components/Button.tsx)
  2. Add tooltip on file chips showing the full path
  3. Recognize and chipify absolute file paths in @ mention suggestions
  4. Add fileExists tRPC endpoint to validate absolute paths before suggesting them

How did you test this?

Manually

@charlesvien charlesvien changed the title Show parent directory in file mention chips fix: Show parent directory in file mention chips Apr 2, 2026
@charlesvien charlesvien marked this pull request as ready for review April 2, 2026 22:20
@charlesvien charlesvien force-pushed the 04-02-fix_enter_key_blocked_empty_suggestion_popup branch from a92e5cb to f8e0608 Compare April 2, 2026 22:38
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from 2778d5d to 07034bc Compare April 2, 2026 22:38
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from 07034bc to e61c796 Compare April 2, 2026 22:55
@charlesvien charlesvien force-pushed the 04-02-fix_enter_key_blocked_empty_suggestion_popup branch from f8e0608 to b6525f2 Compare April 2, 2026 22:55
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from e61c796 to 2d55dd4 Compare April 2, 2026 22:56
@charlesvien charlesvien force-pushed the 04-02-fix_enter_key_blocked_empty_suggestion_popup branch 2 times, most recently from b450f66 to 121d6bb Compare April 2, 2026 22:57
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from 2d55dd4 to 22aba4d Compare April 2, 2026 22:57
@charlesvien charlesvien force-pushed the 04-02-fix_enter_key_blocked_empty_suggestion_popup branch from 121d6bb to ad9e547 Compare April 2, 2026 23:33
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from 22aba4d to 8a048b6 Compare April 2, 2026 23:33
@charlesvien charlesvien force-pushed the 04-02-fix_enter_key_blocked_empty_suggestion_popup branch from ad9e547 to ed7b176 Compare April 3, 2026 00:56
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from a5bbd4c to 453d650 Compare April 3, 2026 00:56
Copy link
Copy Markdown
Member Author

charlesvien commented Apr 3, 2026

Merge activity

  • Apr 3, 1:05 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 3, 1:26 AM UTC: Graphite rebased this pull request as part of a merge.

@charlesvien charlesvien changed the base branch from 04-02-fix_enter_key_blocked_empty_suggestion_popup to graphite-base/1472 April 3, 2026 01:19
@charlesvien charlesvien changed the base branch from graphite-base/1472 to main April 3, 2026 01:25
@charlesvien charlesvien force-pushed the 04-02-file_chip_improvements branch from 453d650 to e3bc1be Compare April 3, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants