ENG-1274: Migrate feature flags

[sid597]

https://www.loom.com/share/cafa18f38454407f85b2f25da6a5180e

new checkbox component for feature flag get and set in props, migrate to block prop based settings

use getFeatureFlag()

rerender left sidebar on enable/disable

---

[linear]

ENG-1274 Add feature flags in settings

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

• ENG-1274: Migrate feature flags #684 👈 (View in Graphite)
• ENG-1345: Modify existing RoamJS component onChange to also change props #745 : 1 other dependent PR (#688 )
• ENG-1190 Replace existing roam-js components with blockProp based ones #689
• ENG-1188: prod: pull watchers for prop based settings #682
• ENG-1187: Prod: Implement get and set for block prop based settings #669
• ENG-1189: Prod: Init block prop based schema #666
• ENG-1330: zod schema for discourse relations #719
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[devin-ai-integration]

Devin Review found 1 new potential issue.

View issue and 12 additional flags in Devin Review.

[devin-ai-integration]

🔴 Pull watchers for feature flags are never initialized

The setupPullWatchOnSettingsPage function is defined in pullWatchers.ts but is never called anywhere in the codebase. This means the feature flag change handlers will never be triggered.

Click to expand

Impact

When users toggle feature flags via the FeatureFlagPanel component:

1. setFeatureFlag is called (accessors.ts:277-286)
2. The block props are updated in Roam
3. But the pull watcher that should detect this change and call the handlers is never set up
4. emitFeatureFlagChange is never called
5. React components using useFeatureFlag hook won't re-render
6. Side effects like remountLeftSidebar(), unmountLeftSidebar(), initializeSupabaseSync(), and setSyncActivity() will never execute

Actual vs Expected

Actual: The feature flag handlers in pullWatchers.ts:96-121 are defined but never invoked because setupPullWatchOnSettingsPage is never called.

Expected: setupPullWatchOnSettingsPage should be called during plugin initialization (e.g., in index.ts) to set up the pull watchers that trigger the handlers when feature flags change.

Evidence

Searching the codebase shows setupPullWatchOnSettingsPage is only exported, never imported or called:

apps/roam/src/components/settings/utils/pullWatchers.ts:export const setupPullWatchOnSettingsPage = (

(Refers to lines 184-253)

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[sid597]

Closing because too many changes that we don't want to merge in main at this point