Skip to content

Conversation

@andre-gielow-ttd
Copy link
Contributor

@andre-gielow-ttd andre-gielow-ttd commented Jul 3, 2025

🔧 Type of changes

  • new bid adapter
  • [ x ] bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

The publisher of intermediary mush inform either supplySourceId or a default in the thetradedesk.yaml file to be used.

🧠 Rationale behind the change

If none is specified a malformed will be formed and send request to TheTradeDesk servers that cannot be resolved.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Simple unit tests

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@andre-gielow-ttd
Copy link
Contributor Author

Go MR: prebid/prebid-server#4419

@andre-gielow-ttd andre-gielow-ttd force-pushed the master branch 3 times, most recently from 6e45aea to 82f566e Compare July 15, 2025 14:54
@andre-gielow-ttd andre-gielow-ttd force-pushed the master branch 2 times, most recently from dfb9114 to 3d943d3 Compare July 16, 2025 13:32
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Jul 16, 2025
@andre-gielow-ttd
Copy link
Contributor Author

@CTMBNara can you take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants