-
Notifications
You must be signed in to change notification settings - Fork 224
TheTradeDesk throw error for malformed endpoint url #4047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Go MR: prebid/prebid-server#4419 |
khang-vu-ttd
reviewed
Jul 8, 2025
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Outdated
Show resolved
Hide resolved
6e45aea to
82f566e
Compare
AntoxaAntoxic
requested changes
Jul 16, 2025
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Outdated
Show resolved
Hide resolved
dfb9114 to
3d943d3
Compare
AntoxaAntoxic
previously approved these changes
Jul 16, 2025
Contributor
Author
|
@CTMBNara can you take another look? |
CTMBNara
requested changes
Jul 23, 2025
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Show resolved
Hide resolved
21 tasks
CTMBNara
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
The publisher of intermediary mush inform either supplySourceId or a default in the thetradedesk.yaml file to be used.
🧠 Rationale behind the change
If none is specified a malformed will be formed and send request to TheTradeDesk servers that cannot be resolved.
🔎 New Bid Adapter Checklist
🧪 Test plan
Simple unit tests
🏎 Quality check