Skip to content

Conversation

@andre-gielow-ttd
Copy link
Contributor

@andre-gielow-ttd andre-gielow-ttd commented Jul 24, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

Go MR: prebid/prebid-server#4448

@andre-gielow-ttd andre-gielow-ttd force-pushed the arg-resolve-auction-price-macro branch 4 times, most recently from f6fa12e to c32d44e Compare July 24, 2025 00:31
@Net-burst
Copy link
Collaborator

@andre-gielow-ttd hi. 2 things:

  1. you incorporated changes from TheTradeDesk throw error for malformed endpoint url #4047 in this PR. Please keep that separate to avoid merge conflicts and confusion or name this PR appropriately and close the old PR.
  2. your updated class doesn't compile for multiple reasons. Please resolve those before we can do a proper review.

Thanks.

@andre-gielow-ttd andre-gielow-ttd force-pushed the arg-resolve-auction-price-macro branch 7 times, most recently from 4f90248 to d663408 Compare July 24, 2025 15:59
@AntoxaAntoxic
Copy link
Collaborator

The PBS Go pull request is prebid/prebid-server#4448

@andre-gielow-ttd andre-gielow-ttd force-pushed the arg-resolve-auction-price-macro branch from ee98c2f to 7c8274d Compare July 28, 2025 13:29
@CTMBNara CTMBNara merged commit d1b64ac into prebid:master Jul 29, 2025
7 of 8 checks passed
@AntoxaAntoxic AntoxaAntoxic linked an issue Jul 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: TheTradeDesk: Resolve AUCTION_PRICE macro

4 participants