-
Notifications
You must be signed in to change notification settings - Fork 224
TheTradeDesk: Resolve AUCTION_PRICE macro #4081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CTMBNara
merged 1 commit into
prebid:master
from
andre-gielow-ttd:arg-resolve-auction-price-macro
Jul 29, 2025
Merged
TheTradeDesk: Resolve AUCTION_PRICE macro #4081
CTMBNara
merged 1 commit into
prebid:master
from
andre-gielow-ttd:arg-resolve-auction-price-macro
Jul 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6fa12e to
c32d44e
Compare
Collaborator
|
@andre-gielow-ttd hi. 2 things:
Thanks. |
AntoxaAntoxic
requested changes
Jul 24, 2025
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java
Outdated
Show resolved
Hide resolved
4f90248 to
d663408
Compare
src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java
Outdated
Show resolved
Hide resolved
Collaborator
|
The PBS Go pull request is prebid/prebid-server#4448 |
d663408 to
ee98c2f
Compare
AntoxaAntoxic
requested changes
Jul 28, 2025
src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java
Show resolved
Hide resolved
ee98c2f to
7c8274d
Compare
AntoxaAntoxic
approved these changes
Jul 28, 2025
CTMBNara
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check
Go MR: prebid/prebid-server#4448