arg-ttd-exception-for-malformed-endpoint

Author: andre-gielow-ttd

src/main/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidder.java

@@ -166,6 +166,10 @@ private static App modifyApp(BidRequest request, String publisherId) {
     }
 
     private String resolveEndpoint(String sourceSupplyId) {
+        if (sourceSupplyId == null && supplyId == null) {
+            throw new PreBidException("Either supplySourceId or a default endpoint must be provided");
+        }
+        
         return endpointUrl.replace(
                 SUPPLY_ID_MACRO,
                 HttpUtil.encodeUrl(StringUtils.defaultString(ObjectUtils.defaultIfNull(sourceSupplyId, supplyId))));

src/test/java/org/prebid/server/bidder/thetradedesk/TheTradeDeskBidderTest.java

@@ -186,6 +186,21 @@ public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() {
         assertThat(result.getValue()).isEmpty();
     }
 
+    @Test
+    public void makeHttpRequestsShouldReturnErrorWhenBothSupplySourceIdAndSupplyIdAreNull() {
+        final TheTradeDeskBidder bidderWithNullSupplyId = new TheTradeDeskBidder(ENDPOINT_URL, jacksonMapper, null);
+        final BidRequest bidRequest = givenBidRequest(
+                identity(),
+                imp -> imp.ext(impExt("publisher", null)));
+
+        final Result<List<HttpRequest<BidRequest>>> result = bidderWithNullSupplyId.makeHttpRequests(bidRequest);
+
+        assertThat(result.getErrors()).hasSize(1);
+        assertThat(result.getErrors().getFirst().getMessage())
+                .isEqualTo("Either supplySourceId or a default endpoint must be provided");
+        assertThat(result.getValue()).isEmpty();
+    }
+
     @Test
     public void makeHttpRequestsShouldReturnSiteWithExtImpPublisherWhenSiteAndAppArePresent() {
         final BidRequest bidRequest = givenBidRequest(