-
Notifications
You must be signed in to change notification settings - Fork 59
Use setup-envtest@release-0.22 for nova #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup-envtest@release-0.22 for nova #1029
Conversation
| # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. | ||
| ENVTEST_K8S_VERSION = 1.31 | ||
|
|
||
| SETUP_ENVTEST_VERSION ?= release-0.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. 0.22 is released with golang 1.24 while main is already using golang 1.25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to know thanks for checking that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we need this for watcher operator too ill go do that now.
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0d8f7e91b5a6467bb2001058c7cbd328 ✔️ openstack-meta-content-provider SUCCESS in 2h 13m 04s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/38327a783761472f90991baf943046a2 ✔️ openstack-meta-content-provider SUCCESS in 2h 18m 04s |
It seems that Tempest tests are failing. This can't be related to this change...or can it? |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/64df10b1aa9746458f05ce49bc58b87e ✔️ openstack-meta-content-provider SUCCESS in 1h 51m 00s |
Confirmed that the failure is unrelated to this PR [1]. Something is broken in Nova Zuul CI. [1] #1031 (comment) |
kubernetes-sigs/controller-runtime#3349 has updated golang to 1.25 in controller-runtime.
99f926d to
632ed4e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aa5ebd3fbc1a4298b60530b0100f2fdb ❌ openstack-meta-content-provider NODE_FAILURE Node request 100-0008064751 failed in 0s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/65f576d4ac8a46b2a8e10174e7652675 ✔️ openstack-meta-content-provider SUCCESS in 33m 00s |
|
check-rdo |
|
the jobs failed because of issue connecting to rpm repos which is not related to this change |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/995ac2e0dfe641309e392344f07ca22f ✔️ openstack-meta-content-provider SUCCESS in 1h 51m 42s |
|
check-rdo |
|
Previously, Tempest runs started failing after some time due to connectivity issues, for example: |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b5e10af27e0d4dd1a4e19283f94d8f49 ✔️ openstack-meta-content-provider SUCCESS in 2h 18m 37s |
|
@mrkisaolamb could this be a side effect of #1017 and the job is just running with less resources? |
mrkisaolamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, gibizer, mrkisaolamb, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We landed a revert of the zuul job node label. So that job should be better now |
a61d2a7
into
openstack-k8s-operators:main
|
\o/ |
|
/cherry-pick 18.0-fr4 |
|
@gibizer: new pull request created: #1036 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary