Update nova-operator to gophercloud v2 #1025

stuggi · 2025-10-01T06:02:49Z

Migrate from gophercloud v1.14.1 to v2.8.0:

Update go.mod dependency and import paths
Add context parameters to API calls (List, Delete)
Handle DeleteResult return type from services.Delete()
Add Nova API version discovery endpoint in test fixture

Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior.

Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type.

Jira: OSPRH-18162
Jira: OSPRH-18319

Depends-On: openstack-k8s-operators/lib-common#645
Depends-On: openstack-k8s-operators/keystone-operator#635
Depends-On: openstack-k8s-operators/ci-framework#3438

AssistedBy: cloude-4-sonnet

softwarefactory-project-zuul · 2025-10-01T06:03:02Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/keystone-operator for 635,b8abbe99eaf84706421b2d38d3a489f34b31d879

softwarefactory-project-zuul · 2025-10-01T06:36:18Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/keystone-operator for 635,b8abbe99eaf84706421b2d38d3a489f34b31d879

gibizer

Thanks @stuggi to taking care of it! Extra kudos for fixing the api fixture as well. The direction looks good to me. Let me know when the dependencies land and I will approve it again.

test/functional/api_fixture.go

softwarefactory-project-zuul · 2025-10-02T11:08:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf41be6ed69c459abfedba2e3a5cd94f

❌ openstack-meta-content-provider FAILURE in 20m 47s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

stuggi · 2025-10-22T06:26:51Z

needs #1029 first

softwarefactory-project-zuul · 2025-10-22T08:11:24Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a48575caa60348db8af9c3e578685b30

✔️ openstack-meta-content-provider SUCCESS in 1h 52m 56s
✔️ nova-operator-kuttl SUCCESS in 39m 04s
❌ nova-operator-tempest-multinode FAILURE in 1h 30m 31s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 30m 15s

stuggi · 2025-10-22T14:51:33Z

recheck

stuggi · 2025-10-22T14:51:40Z

/retest

Migrate from gophercloud v1.14.1 to v2.8.0: - Update go.mod dependency and import paths - Add context parameters to API calls (List, Delete) - Handle DeleteResult return type from services.Delete() - Add Nova API version discovery endpoint in test fixture Gophercloud v2 requires context for all API operations and performs version discovery via GET / before other API calls. Updated test fixture to support this new behavior. Retained local Service struct in test fixture for test isolation and to avoid JSON marshalling complications with gophercloud v2's Service type. Jira: OSPRH-18162 Depends-On: openstack-k8s-operators/lib-common#645 Depends-On: openstack-k8s-operators/keystone-operator#635 AssistedBy: cloude-4-sonnet Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

stuggi · 2025-10-22T15:00:34Z

recheck

softwarefactory-project-zuul · 2025-10-22T16:49:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f9081931c92342a29253f57ee39a3536

✔️ openstack-meta-content-provider SUCCESS in 1h 47m 12s
✔️ nova-operator-kuttl SUCCESS in 41m 31s
❌ nova-operator-tempest-multinode FAILURE in 1h 29m 32s
❌ nova-operator-tempest-multinode-ceph FAILURE in 1h 23m 28s

stuggi · 2025-10-23T06:46:24Z

/retest

stuggi · 2025-10-23T07:05:58Z

hmm seems zuul jobs no longer get triggered? same in this test PR #1037

mrkisaolamb · 2025-10-23T08:43:21Z

recheck

stuggi · 2025-10-24T13:01:30Z

testing in #1037 a different nodeset, the same as configured for watcher. with this the job gets triggered at least.

stuggi · 2025-10-27T09:51:10Z

added a commit to this PR to configure the same nodeset as its configured in watcher. with this zuul checks in test PR #1037 got triggered and passed.

softwarefactory-project-zuul · 2025-10-27T10:30:03Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e66cd95080ab4daaa4988967aba57d76

✔️ openstack-meta-content-provider SUCCESS in 39m 18s
❌ nova-operator-kuttl RETRY_LIMIT in 14m 40s
❌ nova-operator-tempest-multinode FAILURE in 20m 20s
❌ nova-operator-tempest-multinode-ceph FAILURE in 21m 43s

stuggi · 2025-10-27T10:54:53Z

recheck

softwarefactory-project-zuul · 2025-10-27T14:07:55Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/de62a9e9582e444db4a741a1ff3196ac

✔️ openstack-meta-content-provider SUCCESS in 3h 11m 54s
❌ nova-operator-kuttl RETRY_LIMIT in 15m 15s
❌ nova-operator-tempest-multinode FAILURE in 20m 17s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 49m 06s

stuggi · 2025-10-28T07:29:52Z

added a commit to this PR to configure the same nodeset as its configured in watcher. with this zuul checks in test PR #1037 got triggered and passed.

remove that commit from this PR since there was a temporary issue with zuul jobs, not related to the configured nodeset.

softwarefactory-project-zuul · 2025-10-28T08:14:07Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ded104339ef84d22bce27b8830c973c0

✔️ openstack-meta-content-provider SUCCESS in 45m 45s
❌ nova-operator-kuttl RETRY_LIMIT in 15m 13s
❌ nova-operator-tempest-multinode FAILURE in 23m 33s
❌ nova-operator-tempest-multinode-ceph FAILURE in 20m 00s

stuggi · 2025-10-28T09:56:16Z

recheck

softwarefactory-project-zuul · 2025-10-28T13:12:50Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f37b09125ee84f17af4007221c001a6e

✔️ openstack-meta-content-provider SUCCESS in 3h 10m 41s
❌ nova-operator-kuttl RETRY_LIMIT in 16m 13s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 13m 35s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 48m 00s

stuggi · 2025-10-28T16:00:33Z

kuttl job fails with ''cifmw_installyamls_repos'' is undefined' -> #1039

stuggi · 2025-10-29T07:28:46Z

recheck

softwarefactory-project-zuul · 2025-10-29T08:33:59Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/766a0b9761854ecdb963f7625b99df06

✔️ openstack-meta-content-provider SUCCESS in 59m 42s
✔️ nova-operator-kuttl SUCCESS in 37m 04s
❌ nova-operator-tempest-multinode FAILURE in 21m 20s
❌ nova-operator-tempest-multinode-ceph FAILURE in 23m 45s

stuggi · 2025-10-29T09:27:10Z

recheck

mrkisaolamb

lgtm

openshift-ci · 2025-10-29T13:13:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrkisaolamb, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gibizer,mrkisaolamb,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stuggi added the do-not-merge/hold label Oct 1, 2025

openshift-ci bot requested review from bogdando and kk7ds October 1, 2025 06:02

openshift-ci bot added the approved label Oct 1, 2025

stuggi force-pushed the gophercloud_2 branch from fb53556 to 2d864c6 Compare October 1, 2025 06:36

gibizer approved these changes Oct 1, 2025

View reviewed changes

openshift-ci bot assigned gibizer Oct 1, 2025

openshift-ci bot added the lgtm label Oct 1, 2025

gibizer reviewed Oct 1, 2025

View reviewed changes

test/functional/api_fixture.go Outdated Show resolved Hide resolved

stuggi force-pushed the gophercloud_2 branch from 2d864c6 to 8f87e8e Compare October 2, 2025 10:45

openshift-ci bot removed the lgtm label Oct 2, 2025

openshift-merge-robot added the needs-rebase label Oct 3, 2025

stuggi force-pushed the gophercloud_2 branch from 8f87e8e to b2cb741 Compare October 22, 2025 06:17

openshift-merge-robot removed the needs-rebase label Oct 22, 2025

stuggi removed the do-not-merge/hold label Oct 22, 2025

stuggi force-pushed the gophercloud_2 branch from b2cb741 to 8e4b0da Compare October 23, 2025 06:19

stuggi force-pushed the gophercloud_2 branch from 0e0edcd to 8e4b0da Compare October 28, 2025 07:27

stuggi mentioned this pull request Oct 29, 2025

Add cifmw_installyamls_repos variable for the kuttl job #1039

Closed

stuggi mentioned this pull request Oct 29, 2025

Read group_vars/all.yml in each nested Ansible execution in ci playbooks openstack-k8s-operators/ci-framework#3438

Merged

mrkisaolamb approved these changes Oct 29, 2025

View reviewed changes

openshift-ci bot assigned mrkisaolamb Oct 29, 2025

openshift-ci bot added the lgtm label Oct 29, 2025

mrkisaolamb added do-not-merge/hold and removed do-not-merge/hold labels Oct 29, 2025

openshift-merge-bot bot merged commit 4642ff1 into openstack-k8s-operators:main Oct 29, 2025
9 checks passed

Update nova-operator to gophercloud v2 #1025

Update nova-operator to gophercloud v2 #1025

Conversation

stuggi commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Oct 1, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 1, 2025

Uh oh!

gibizer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Oct 2, 2025

Uh oh!

stuggi commented Oct 22, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 22, 2025

Uh oh!

stuggi commented Oct 22, 2025

Uh oh!

stuggi commented Oct 22, 2025

Uh oh!

stuggi commented Oct 22, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 22, 2025

Uh oh!

stuggi commented Oct 23, 2025

Uh oh!

stuggi commented Oct 23, 2025

Uh oh!

mrkisaolamb commented Oct 23, 2025

Uh oh!

stuggi commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuggi commented Oct 27, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 27, 2025

Uh oh!

stuggi commented Oct 27, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 27, 2025

Uh oh!

stuggi commented Oct 28, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 28, 2025

Uh oh!

stuggi commented Oct 28, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 28, 2025

Uh oh!

stuggi commented Oct 28, 2025

Uh oh!

stuggi commented Oct 29, 2025

Uh oh!

softwarefactory-project-zuul bot commented Oct 29, 2025

Uh oh!

stuggi commented Oct 29, 2025

Uh oh!

mrkisaolamb left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stuggi commented Oct 1, 2025 •

edited

Loading

stuggi commented Oct 24, 2025 •

edited

Loading