-
Notifications
You must be signed in to change notification settings - Fork 26
pin setup-envtest release #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin setup-envtest release #293
Conversation
This change pins the version of setup-envtest to release 0.22 which is the most recent release to use golan 1.24 latest now uses 1.25 and is not compatible with the operator as a result
|
This is effectively a port of openstack-k8s-operators/nova-operator#1029 to keep the watcher-operator in sync |
|
/test functional |
|
looks like we might have a flaky test but i think that is unrelated to this change |
abays
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/cherry-pick 18.0-fr4 |
|
@abays: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
89fa1b1
into
openstack-k8s-operators:main
|
@abays: new pull request created: #294 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This change pins the version of setup-envtest to release 0.22
which is the most recent release to use golan 1.24
latest now uses 1.25 and is not compatible with the operator as a
result