Skip to content

Conversation

@SeanMooney
Copy link
Collaborator

This change pins the version of setup-envtest to release 0.22
which is the most recent release to use golan 1.24
latest now uses 1.25 and is not compatible with the operator as a
result

This change pins the version of setup-envtest to release 0.22
which is the most recent release to use golan 1.24
latest now uses 1.25 and is not compatible with the operator as a
result
@openshift-ci openshift-ci bot requested review from olliewalsh and rlandy October 14, 2025 15:47
@SeanMooney
Copy link
Collaborator Author

This is effectively a port of openstack-k8s-operators/nova-operator#1029 to keep the watcher-operator in sync

@SeanMooney
Copy link
Collaborator Author

/test functional

@SeanMooney
Copy link
Collaborator Author

looks like we might have a flaky test but i think that is unrelated to this change

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abays
Copy link
Contributor

abays commented Oct 15, 2025

/cherry-pick 18.0-fr4

@openshift-cherrypick-robot

@abays: once the present PR merges, I will cherry-pick it on top of 18.0-fr4 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raukadah
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 89fa1b1 into openstack-k8s-operators:main Oct 15, 2025
6 checks passed
@openshift-cherrypick-robot

@abays: new pull request created: #294

Details

In response to this:

/cherry-pick 18.0-fr4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants