Skip to content

Conversation

@adinauer
Copy link
Member

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@adinauer adinauer requested a review from a team as a code owner January 19, 2026 12:37
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 19, 2026
Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
@adinauer adinauer changed the base branch from master to feat/java-metrics-onboarding January 19, 2026 13:58

// List of platforms that have metrics onboarding checklist content
export const withMetricsOnboarding: Set<PlatformKey> = new Set([
'android',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Adding 'android' to withMetricsOnboarding is incorrect as the Android docs module lacks a metricsOnboarding export, leading to a blank page for users.
Severity: MEDIUM

Suggested Fix

Remove 'android' from the withMetricsOnboarding set. This change should be reverted until the Android documentation module is updated to include and export the metricsOnboarding content.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/data/platformCategories.tsx#L386

Potential issue: The code change adds 'android' to the `withMetricsOnboarding` set,
which signals that metrics onboarding documentation is available for the Android
platform. However, the corresponding documentation module for Android, located at
`static/app/gettingStartedDocs/android/index.tsx`, does not export a `metricsOnboarding`
property. When a user with an Android project attempts to view this documentation, the
`useLoadGettingStarted.ts` hook will successfully load the module but will find that
`module.default.metricsOnboarding` is `undefined`. This results in the user being shown
no content, creating a broken user experience.

Did we get this right? 👍 / 👎 to inform future reviews.

@adinauer adinauer merged commit 51bc154 into feat/java-metrics-onboarding Jan 19, 2026
47 of 49 checks passed
@adinauer adinauer deleted the feat/tracemetrics-add-java-and-android-to-supported-platforms branch January 19, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants