Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions static/app/data/platformCategories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,12 @@ export const withoutLoggingSupport: Set<PlatformKey> = new Set(['elixir']);

// List of platforms that have metrics onboarding checklist content
export const withMetricsOnboarding: Set<PlatformKey> = new Set([
'android',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Adding 'android' to withMetricsOnboarding is incorrect as the Android docs module lacks a metricsOnboarding export, leading to a blank page for users.
Severity: MEDIUM

Suggested Fix

Remove 'android' from the withMetricsOnboarding set. This change should be reverted until the Android documentation module is updated to include and export the metricsOnboarding content.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/data/platformCategories.tsx#L386

Potential issue: The code change adds 'android' to the `withMetricsOnboarding` set,
which signals that metrics onboarding documentation is available for the Android
platform. However, the corresponding documentation module for Android, located at
`static/app/gettingStartedDocs/android/index.tsx`, does not export a `metricsOnboarding`
property. When a user with an Android project attempts to view this documentation, the
`useLoadGettingStarted.ts` hook will successfully load the module but will find that
`module.default.metricsOnboarding` is `undefined`. This results in the user being shown
no content, creating a broken user experience.

Did we get this right? 👍 / 👎 to inform future reviews.

'java',
'java-log4j2',
'java-logback',
'java-spring',
'java-spring-boot',
'javascript',
'javascript-angular',
'javascript-astro',
Expand Down Expand Up @@ -445,6 +451,8 @@ export const withMetricsOnboarding: Set<PlatformKey> = new Set([
export const withoutMetricsSupport: Set<PlatformKey> = new Set([]);

export const limitedMetricsSupportPrefixes: Set<string> = new Set([
'android',
'java',
'javascript',
'node',
'python',
Expand Down
Loading