Add Metrics to Java onboarding #106508

adinauer · 2026-01-19T09:43:18Z

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

lbloder · 2026-01-19T13:22:23Z

static/app/gettingStartedDocs/java/metrics.tsx

+  ],
+});
+
+export const metrics = <


Looks like the java platforms (java, java-log4j, java-spring, etc) are missing in the withMetricsOnboarding Set in platformCategories.tsx.

Then it shows up in Explore > Metrics.

This is changed in #106513

lbloder

LGTM 👍

static/app/components/onboarding/productSelection.tsx

)   ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. --------- Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>

static/app/data/platformCategories.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

static/app/data/platformCategories.tsx

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

static/app/gettingStartedDocs/android/metrics.tsx

static/app/components/onboarding/productSelection.tsx

sentry · 2026-01-20T07:48:40Z

static/app/components/onboarding/productSelection.tsx

+    ProductSolution.LOGS,
+    ProductSolution.METRICS,
+  ],
+  'java-spring-boot': [
+    ProductSolution.PERFORMANCE_MONITORING,
+    ProductSolution.LOGS,
+    ProductSolution.METRICS,
+  ],
  javascript: [
    ProductSolution.PERFORMANCE_MONITORING,
    ProductSolution.SESSION_REPLAY,


Bug: The 'android' platform is missing from the platformProductAvailability object, which will prevent the product selection UI from rendering during onboarding for Android projects.
_{Severity: MEDIUM}

Suggested Fix

Add an entry for the 'android' platform to the platformProductAvailability object in static/app/components/onboarding/productSelection.tsx, similar to the other platforms. This entry should list the available products for Android, such as profiling, replay, and metrics.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: static/app/components/onboarding/productSelection.tsx#L112-L142 Potential issue: The 'android' platform is missing from the `platformProductAvailability` object in `productSelection.tsx`. While the PR adds metrics onboarding documentation for Android, this omission will cause the `ProductSelection` component to look up `platformProductAvailability['android']`, receive `undefined`, and consequently return `null`. This prevents users from seeing or selecting any products (like Metrics, Logs, or Replay) during the onboarding flow for a new Android project, making the feature incomplete for this platform.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

Product selection is not available on Android platforms. Instead, we offer a command-line wizard or a link to the documentation for manual instrumentation.

priscilawebdev · 2026-01-20T09:17:03Z

static/app/components/onboarding/productSelection.tsx

+    ProductSolution.LOGS,
+    ProductSolution.METRICS,
+  ],
+  'java-spring-boot': [
+    ProductSolution.PERFORMANCE_MONITORING,
+    ProductSolution.LOGS,
+    ProductSolution.METRICS,
+  ],
  javascript: [
    ProductSolution.PERFORMANCE_MONITORING,
    ProductSolution.SESSION_REPLAY,


Product selection is not available on Android platforms. Instead, we offer a command-line wizard or a link to the documentation for manual instrumentation.

priscilawebdev · 2026-01-20T09:20:07Z

static/app/data/platformCategories.tsx


 export const limitedMetricsSupportPrefixes: Set<string> = new Set([
+  'android',
+  'java',


Are we listing only java because it serves as a prefix for java-logback, java-log4j2, java-spring, and java-spring-boot?

priscilawebdev · 2026-01-20T09:22:56Z

static/app/gettingStartedDocs/android/metrics.tsx

+          text: tct(
+            "To start using metrics, make sure your Sentry Android SDK version is [code] or higher. If you're on an older version of the SDK, follow our [link:migration guide] to upgrade.",
+            {
+              code: (
+                <code>{getPackageVersion(params, 'sentry.java.android', '8.30.0')}</code>
+              ),
+              link: (
+                <ExternalLink href="https://docs.sentry.io/platforms/android/migration/" />
+              ),
+            }
+          ),


nit:

Suggested change

text: tct(

"To start using metrics, make sure your Sentry Android SDK version is [code] or higher. If you're on an older version of the SDK, follow our [link:migration guide] to upgrade.",

{

code: (

<code>{getPackageVersion(params, 'sentry.java.android', '8.30.0')}</code>

),

link: (

<ExternalLink href="https://docs.sentry.io/platforms/android/migration/" />

),

}

),

text: tct(

"To start using metrics, make sure your Sentry Android SDK version is [version] or higher. If you're on an older version of the SDK, follow our [link:migration guide] to upgrade.",

{

version: (

<code>{getPackageVersion(params, 'sentry.java.android', '8.30.0')}</code>

),

link: (

<ExternalLink href="https://docs.sentry.io/platforms/android/migration/" />

),

}

),

priscilawebdev · 2026-01-20T09:28:42Z

static/app/gettingStartedDocs/android/metrics.tsx

+export const metricsVerify = <
+  PlatformOptions extends BasePlatformOptions = BasePlatformOptions,
+>(
+  params: DocsParams<PlatformOptions>
+): ContentBlock => ({
+  type: 'conditional',
+  condition: params.isMetricsSelected,
+  content: [
+    {
+      type: 'text',
+      text: t(
+        'Send test metrics from your app to verify metrics are arriving in Sentry.'
+      ),
+    },
+    {
+      type: 'code',
+      tabs: [
+        {
+          label: 'Java',
+          language: 'java',
+          code: getMetricsVerifyJavaSnippet(),
+        },
+        {
+          label: 'Kotlin',
+          language: 'kotlin',
+          code: getMetricsVerifyKotlinSnippet(),
+        },
+      ],
+    },
+  ],
+});


It appears that this function is not used anywhere. Knip may be failing in this PR, though I haven’t confirmed yet.

priscilawebdev · 2026-01-20T09:29:34Z

static/app/gettingStartedDocs/android/metrics.tsx

+
+${getMetricsCodeJava()}`;
+
+export const getMetricsVerifyKotlinSnippet = () => `import io.sentry.Sentry


this is only being used in the metricsVerify which is not used anywhere. we should do a cleanup in this file.

priscilawebdev · 2026-01-20T09:31:36Z

static/app/gettingStartedDocs/java/metrics.tsx

+        {
+          type: 'text',
+          text: tct(
+            "To start using metrics, make sure your Sentry Java SDK version is [code:8.30.0] or higher. If you're on an older version of the SDK, follow our [link:migration guide] to upgrade.",


nit: should we say version here?

priscilawebdev · 2026-01-20T09:32:25Z

static/app/gettingStartedDocs/java/metrics.tsx

+  docsPlatform,
+}: {
+  docsPlatform: string;


nit: maybe java can be the default? or do we want to force developers to always inform the platform?

priscilawebdev · 2026-01-20T09:36:10Z

static/app/gettingStartedDocs/java-spring/index.tsx

  replayOnboardingJsLoader,
  feedbackOnboardingJsLoader,
  logsOnboarding: logs,
+  metricsOnboarding: metrics({docsPlatform: 'spring'}),


Based on what I observed, if we remove the java- prefix, the names are identical. I propose we avoid making the metrics a function and instead use something like params.platformKey.split('java-')[1] directly.

Add Metrics to Java onboarding

e23bfe0

adinauer requested a review from a team as a code owner January 19, 2026 09:43

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 19, 2026

vercel bot deployed to Preview January 19, 2026 09:45 View deployment

lbloder reviewed Jan 19, 2026

View reviewed changes

lbloder approved these changes Jan 19, 2026

View reviewed changes

Merge branch 'master' into feat/java-metrics-onboarding

92f8a4f

vercel bot deployed to Preview January 19, 2026 13:55 View deployment

sentry bot reviewed Jan 19, 2026

View reviewed changes

static/app/components/onboarding/productSelection.tsx Show resolved Hide resolved

vercel bot deployed to Preview January 19, 2026 14:23 View deployment

sentry bot reviewed Jan 19, 2026

View reviewed changes

static/app/data/platformCategories.tsx Show resolved Hide resolved

cursor bot reviewed Jan 19, 2026

View reviewed changes

static/app/data/platformCategories.tsx Show resolved Hide resolved

Metrics onboarding docs for Android

9d55c0b

vercel bot deployed to Preview January 19, 2026 14:46 View deployment

cursor bot reviewed Jan 19, 2026

View reviewed changes

static/app/gettingStartedDocs/android/metrics.tsx Show resolved Hide resolved

adinauer added 2 commits January 19, 2026 15:56

fix test

1119ab0

fix android version

d3d9e73

vercel bot deployed to Preview January 19, 2026 14:59 View deployment

sentry bot reviewed Jan 19, 2026

View reviewed changes

static/app/components/onboarding/productSelection.tsx Show resolved Hide resolved

vercel bot deployed to Preview January 19, 2026 15:02 View deployment

Avoid false positives on tests

b46d3f2

vercel bot deployed to Preview January 19, 2026 15:10 View deployment

Merge branch 'master' into feat/java-metrics-onboarding

628dbbd

vercel bot deployed to Preview January 20, 2026 07:48 View deployment

sentry bot reviewed Jan 20, 2026

View reviewed changes

priscilawebdev reviewed Jan 20, 2026

View reviewed changes


		${getMetricsCodeJava()}`;

		export const getMetricsVerifyKotlinSnippet = () => `import io.sentry.Sentry

Uh oh!

Add Metrics to Java onboarding #106508

Are you sure you want to change the base?

Add Metrics to Java onboarding #106508

Uh oh!

Conversation

adinauer commented Jan 19, 2026

Legal Boilerplate

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbloder left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sentry bot Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants