Skip to content

Conversation

@chargome
Copy link
Member

This new reason can be used when the client drops telemetry items due to failing internal validation (e.g. dropping replays that contain invalid session times)

ref #18316
depends on getsentry/snuba#7654
closes https://linear.app/getsentry/issue/FE-690/update-js-sdk-to-support-client-discard-invalid

@chargome chargome requested a review from Lms24 January 20, 2026 14:56
@chargome chargome self-assigned this Jan 20, 2026
@linear
Copy link

linear bot commented Jan 20, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,614 - 8,763 -2%
GET With Sentry 1,697 20% 1,652 +3%
GET With Sentry (error only) 5,983 69% 6,025 -1%
POST Baseline 1,179 - 1,184 -0%
POST With Sentry 563 48% 582 -3%
POST With Sentry (error only) 1,031 87% 1,028 +0%
MYSQL Baseline 3,248 - 3,300 -2%
MYSQL With Sentry 411 13% 450 -9%
MYSQL With Sentry (error only) 2,623 81% 2,668 -2%

View base workflow run

@chargome chargome force-pushed the cg/FE-690/update-js-sdk-to-support-client-discard-invalid branch from 0f2b3fa to c2139be Compare January 23, 2026 10:18
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

| 'buffer_overflow'
| 'ignored';
| 'ignored'
| 'invalid';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test for new feature

Medium Severity · Bugbot Rules

This feat PR adds the 'invalid' discard reason but includes no integration or E2E tests demonstrating its usage. The new reason type is defined but never used or tested anywhere in the codebase. The PR review rules require at least one integration or E2E test for feature PRs to verify the new functionality works as expected.

Fix in Cursor Fix in Web

@chargome chargome merged commit 58d3206 into develop Jan 23, 2026
211 checks passed
@chargome chargome deleted the cg/FE-690/update-js-sdk-to-support-client-discard-invalid branch January 23, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants