Skip to content

feat(core): Support new client discard reason invalid #18901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chargome merged 1 commit into from
Jan 23, 2026
Merged

feat(core): Support new client discard reason invalid #18901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/types-hoist/clientreport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export type EventDropReason =
| 'send_error'
| 'internal_sdk_error'
| 'buffer_overflow'
| 'ignored';
| 'ignored'
| 'invalid';
Copy link

@cursor cursor bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test for new feature

Medium Severity · Bugbot Rules

This feat PR adds the 'invalid' discard reason but includes no integration or E2E tests demonstrating its usage. The new reason type is defined but never used or tested anywhere in the codebase. The PR review rules require at least one integration or E2E test for feature PRs to verify the new functionality works as expected.

Fix in Cursor Fix in Web


export type Outcome = {
reason: EventDropReason;
Expand Down
Loading