feat(replay): Update client report discard reason for invalid sessions #18796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
reviewed
Jan 19, 2026
Member
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Hey @harshit078 thanks for contributing! For the lack of better options in the drop reasons (see https://develop.sentry.dev/sdk/telemetry/client-reports/#envelope-item-payload) I think the most fitting is still send_error in this case.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
chargome
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
chargome
approved these changes
Jan 23, 2026
andreiborza
approved these changes
Jan 23, 2026
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Awesome, thanks for the contribution!
nicohrubec
pushed a commit
that referenced
this pull request
Jan 23, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #18796 Co-authored-by: chargome <20254395+chargome@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR distinguishes replays that get dropped due to session length vs. transport/ratelimit reasons in the client report.
depends on #18901
closes #18316