Add PrepareResourcesBatchPhases RenderSystem set#22952
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Feb 17, 2026
Merged
Add PrepareResourcesBatchPhases RenderSystem set#22952alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
atlv24
added
A-Rendering
IceSentry
reviewed
Feb 14, 2026
| /// Collect phase buffers after | ||
| /// [`PrepareResources`](RenderSystems::PrepareResources) has run. | ||
| /// A sub-set within [`Prepare`](RenderSystems::Prepare) that creates batches for render phases. | ||
| PrepareResourcesBatchPhases, |
Contributor
There was a problem hiding this comment.
Doesn't that reduce parallelism since now other systems that don't care about batch phases can't run in parallel? I guess both system sets already have plenty of systems in them so it might not matter at all.
Contributor
Author
There was a problem hiding this comment.
yeah im not sure itll be a measurable regression, lets get to ambiguity zero and then see about refining ordering to get parallelism opportunities back imo
IceSentry
approved these changes
Feb 14, 2026
alice-i-cecile
added
C-Code-Quality
alice-i-cecile
approved these changes
Feb 16, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
# Objective - Fix #7386 ## Solution - #22951 #22952 #22949 #22945 and a handful more changes on this PR. NOTE: Ci will not pass until all these other prs are merged. - Fix a bug ## Testing - examples look fine --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: François Mockers <francois.mockers@vleue.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing