Skip to content

Enable RenderApp Ambiguity Detection#22954

Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom
atlv24:ad/render-ambiguities-5
Feb 17, 2026
Merged

Enable RenderApp Ambiguity Detection#22954
alice-i-cecile merged 6 commits intobevyengine:mainfrom
atlv24:ad/render-ambiguities-5

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Feb 14, 2026

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 14, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Feb 14, 2026
@atlv24
Copy link
Copy Markdown
Contributor Author

atlv24 commented Feb 14, 2026

How did CI pass even though my other patches havent merged yet? There should be like 1500 ambiguities still without them merged.

@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 15, 2026
Comment thread tests/ecs/ambiguity_detection.rs
@mockersf
Copy link
Copy Markdown
Member

How did CI pass even though my other patches havent merged yet? There should be like 1500 ambiguities still without them merged.

You configured the test to look for ambiguities, but not to crash if there are some

alice-i-cecile and others added 2 commits February 16, 2026 19:31
Co-authored-by: François Mockers <francois.mockers@vleue.com>
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 17, 2026
Merged via the queue into bevyengine:main with commit 380d2c3 Feb 17, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Deny internal execution order ambiguities in CI

5 participants