-
Notifications
You must be signed in to change notification settings - Fork 154
Update CCSD(T)-F12 AECs and BACs #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
RMG-database runs tests in RMG-Py, which currently cannot properly handle
@xiaoruiDong In conclusion, we have a dilemma. The tests for this PR will not pass until the twin RMG-Py PR is merged; however, the tests for that PR will not pass until this PR is merged since it is the first to add a |
|
Thanks for the contribution, @kspieks. The results look great! It is reasonable for the point you mentioned, since F12 method is known for its faster convergence to the complete basis set values. If you don't mind, can you also post an image here showing the deviation between the values from "TZ" and "DZ". I mean something like `plt.plot(TZ_value - DZ_value) or plt.hist(TZ_value-DZ_value), to make it a good reference for future use. |
|
@mjohnson541 @amarkpayne I am not very familiar with the SOP for twin PR merging. Can you comment on how we can help Kevin test his PRs? Thanks! |
|
Thanks for the review. The histogram below shows the corrected enthalpies of TZ minus DZ. The mean is 0.009 kcal/mol and MAE is 0.157 kcal/mol i.e. TZ and DZ have good agreement. In case someone wants to reproduce this plot in the future, the data was taken from the csv files that are automatically printed by Arkane during BAC fitting, which are stored on the RMG server. |
|
The directions for simultaneous updates are here: https://github.com/ReactionMechanismGenerator/RMG-Py/wiki/Simultaneous-Update-of-RMG-Py-and-RMG-database |
|
@xiaoruiDong @mjohnson541 Using the procedure from Matt's link above, all checks pass which confirm that these two branches are compatible with each other. Please let me know if there are other changes I should make to either PR. Otherwise, I can remove the temporary commit from each PR and rebase them. Thanks! |
|
Please rebase and @me to merge your PR. Thanks |
|
FYI: all log files and Arkane outputs related to these jobs have been copied to my account on our new greencloud sever at |
This PR updates relevant coupled cluster corrections in our database. All input and output files have been added to the RMG server for long term storage. A corresponding RMG-Py PR updates the documentation.
AECs were updated for both
CCSD(T)-F12/cc-pVDZ-F12andCCSD(T)-F12/cc-pVTZ-F12. Single point energies were calculated with MOLPRO.BACs were added for two composite LoTs:
CCSD(T)-F12/cc-pVDZ-F12//ωB97X-D3/def2-TZVPandCCSD(T)-F12/cc-pVTZ-F12//ωB97X-D3/def2-TZVP. Single point energies were calculated with MOLPRO. The geometry optimization and frequency calculations were done with QChem in PR #459. As expected, the errors before and after fitting are much lower than they were for the DFT levels in the previous PR.For
CCSD(T)-F12/cc-pVDZ-F12//ωB97X-D3/def2-TZVP:1_ccsd(t)f12_ccpvdzf12__wb97xd3_def2tzvp_errors.pdf
For
CCSD(T)-F12/cc-pVTZ-F12//ωB97X-D3/def2-TZVP:1_ccsd(t)f12_ccpvtzf12__wb97xd3_def2tzvp_errors.pdf
Note that some reference species were omitted since these two basis sets only support the first three rows of the periodic table (source: https://www.basissetexchange.org/).
An interesting side note is that the error for these reference species after fitting is nearly identical for the two basis sets. However, the TZ basis set is much more expensive; it used 5.6x more CPU time and 5.8x more disk space, which will quickly become infeasible for high throughput analysis of species with many heavy atoms.