-
Notifications
You must be signed in to change notification settings - Fork 250
Update documentation to reflect additions in RMG-database #2175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2175 +/- ##
==========================================
+ Coverage 47.87% 49.39% +1.51%
==========================================
Files 102 102
Lines 27064 29761 +2697
Branches 6944 8402 +1458
==========================================
+ Hits 12957 14700 +1743
- Misses 12720 13468 +748
- Partials 1387 1593 +206
Continue to review full report at Codecov.
|
|
This PR also fixes a bug with
This PR fixes this error and updates @xiaoruiDong Note that the additional test causes this PR's tests to fail due to which is expected since no composite LoT currently exists in RMG-database to overwrite. This unittest will not pass until the twin RMG-database PR is merged. However, the tests for that PR will not pass until this PR is merged. I've checked out the |
85f7f48 to
ab56ef6
Compare
|
Thanks, @kspieks. I just finished my review. My laptop was dead last week, so the review was postponed... Sorry about that. I am fine with your implementations. I added another commit... Just find there is a 5-layer-if-else + a 2 layer for combined together near your modifications, which is not friendly for reviewing. So I refactored the codes and added a few comments. I restarted both the test for RMG-Py and RMG-test for your PRs, and I will let you know once it finishes. If all checks pass, please remove the temporary commits and rebase the branch. I will help you merge them afterward. |
Previously, the code would search for LoT while iterating over lines and overwrite the first instance of the LoT. However, this does not account for partial matches, such as within a Composite LoT
ab56ef6 to
dcd53c7
Compare
|
@xiaoruiDong Thanks for your review and hope your laptop is fine now. I appreciate you making that code section more clear :) It looks good to me so I rebased and removed the temporary git action commit on both this PR and the PR for RMG-database |
This minor PR updates the documentation that tabulates which levels of theory are supported by Arkane. It reflects changes from a recent RMG-database PR, which expanded the supported AEC atom types for coupled cluster calculations with
CCSD(T)-F12/cc-pVDZ-F12andCCSD(T)-F12/cc-pVTZ-F12.