Skip to content

Conversation

@BenjaminAmos
Copy link
Contributor

@BenjaminAmos BenjaminAmos commented Nov 5, 2021

Description

This pull request converts the in-game inventory screen to use NUI. It should function almost identically to before, however it may look a bit different. Any UI design critiques would be appreciated also.

Testing

  • This pull request affects all screens that use the inventory's functionality.
  • The following screens are affected and should be double-checked against an older build to identify possible regressions:
    • TutorialManager
    • BuyItemsScreen
    • SellItemsScreen
    • ChangeShipScreen
    • ChooseMercenaryScreen
    • GiveItemsScreen (give items to a mercenary)
    • HireShipsScreen
    • ShowInventory (the "Items" screen)
    • TakeItems (take items from a mercenary)
  • As a guide, at least the following things should be checked:
    • Is the appearence similar to before (or better)?
    • Do all of the key-bindings work as before?
    • Does the screen function the same as before (or better)?

Notes

@BenjaminAmos
Copy link
Contributor Author

I should have mentioned before that MovingBlocks/TeraNUI#66 and MovingBlocks/TeraNUI#67 contain bug fixes that should help with testing this pull request.

This was referenced Nov 13, 2021
@BenjaminAmos
Copy link
Contributor Author

There is another bug fix for NUI which allows this pull request to render correctly: MovingBlocks/TeraNUI#69.

@BenjaminAmos
Copy link
Contributor Author

This was replaced by #668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant