Skip to content

feat(ci): promote ci junit-upload from shim to native as a deprecated alias#1468

Draft
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4from
devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c
Draft

feat(ci): promote ci junit-upload from shim to native as a deprecated alias#1468
jd wants to merge 1 commit into
devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4from
devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 27, 2026

junit-upload is the deprecated alias for junit-process
Python's mergify_cli/ci/cli.py declares it with click's
deprecated="Use \junit-process` instead"decorator and delegates straight to the sameprocess_junit_filesbody. The shim was still routing it through Python only because the orchestrator wasn't native yet; now that Phase C landed, we can collapse it down to a clap variant that reusesJunitProcessCliArgsand dispatches tomergify_ci::junit_process::runafter printing aDeprecationWarning: …` line to stderr (matches click's behavior
on first invocation).

This retires the last ci shim — prepend_two lost its only
remaining caller and goes with it. stack is now the only
shimmed top-level group left.

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

Depends-On: #1467

@jd
Copy link
Copy Markdown
Member Author

jd commented May 27, 2026

This pull request is part of a Mergify stack:

# Pull Request Link
1 fix(cli): accept --debug on the Rust binary and actually toggle it in Python #1464
2 refactor(rust): share test scaffolding via mergify-test-support crate #1439
3 refactor(core): introduce CommandContext for the queue+freeze prelude #1441
4 refactor(ci): consolidate the CI-env scrubber into a shared testing module #1442
5 refactor: drop stale Phase X.Y doc markers and one inline color branch #1443
6 refactor(tui): share StyledGlyph across queue show/status renderers #1444
7 refactor(queue): drop indexmap, group_by_scope returns a Vec<(K, V)> #1445
8 refactor(ci): swap uuid for getrandom in the GHA heredoc delimiter #1446
9 refactor(config): standardize the workspace on serde_yaml_ng for YAML parsing #1447
10 test(ci): add live smoke test for ci scopes select-all path #1460
11 feat(rust): port ci scopes to native Rust #1461
12 feat(ci): parse JUnit XML reports in native Rust #1465
13 feat(ci): encode JUnit cases as OTLP and upload to Mergify CI Insights #1466
14 feat(ci): promote ci junit-process from shim to native Rust #1467
15 feat(ci): promote ci junit-upload from shim to native as a deprecated alias #1468 👈
16 fix(ci): prefer GitHub Actions PR-event head SHA over GITHUB_SHA #1469

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 27, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 ⛓️ Depends-On Requirements

Waiting for

This rule is failing.

Requirement based on the presence of Depends-On in the body of the pull request

🔴 👀 Review Requirements

Waiting for

  • #approved-reviews-by>=2
This rule is failing.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🔴 🔎 Reviews

Waiting for

  • #review-requested = 0
This rule is failing.
  • #review-requested = 0
  • #changes-requested-reviews-by = 0
  • #review-threads-unresolved = 0

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from 8078737 to ed7a74d Compare May 27, 2026 08:27
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from 57bb83b to bd85763 Compare May 27, 2026 08:27
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:27 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:27 — with GitHub Actions Inactive
@jd
Copy link
Copy Markdown
Member Author

jd commented May 27, 2026

Revision history

# Type Changes Reason Date
1 initial 57bb83b 2026-05-27 08:27 UTC
2 content 57bb83b → bd85763 2026-05-27 08:27 UTC
3 rebase bd85763 → c994e93 (rebase only) 2026-05-27 08:46 UTC
4 content c994e93 → 8460659 2026-05-27 09:00 UTC
5 rebase 8460659 → de0921a (rebase only) 2026-05-27 09:18 UTC
6 rebase de0921a → a823367 (rebase only) 2026-05-27 10:04 UTC
7 rebase a823367 → 7a63271 (rebase only) 2026-05-27 10:15 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 08:28 Failure
@mergify mergify Bot requested a review from a team May 27, 2026 08:42
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from bd85763 to c994e93 Compare May 27, 2026 08:46
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from ed7a74d to 6eeb3d9 Compare May 27, 2026 08:46
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 08:46 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 08:46 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from c994e93 to 8460659 Compare May 27, 2026 09:00
@jd jd temporarily deployed to func-tests-live May 27, 2026 09:00 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 09:00 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from 8460659 to de0921a Compare May 27, 2026 09:18
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from 6317d48 to a353a93 Compare May 27, 2026 09:18
@jd jd temporarily deployed to func-tests-live May 27, 2026 09:18 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 09:19 Failure
@jd jd temporarily deployed to func-tests-live May 27, 2026 09:20 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 09:20 — with GitHub Actions Inactive
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from a353a93 to cc3c840 Compare May 27, 2026 10:04
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from de0921a to a823367 Compare May 27, 2026 10:04
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:04 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:04 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 10:06 Failure
…ed alias

`junit-upload` is the deprecated alias for `junit-process` —
Python's `mergify_cli/ci/cli.py` declares it with click's
`deprecated="Use \`junit-process\` instead"` decorator and
delegates straight to the same `process_junit_files` body. The
shim was still routing it through Python only because the
orchestrator wasn't native yet; now that Phase C landed, we can
collapse it down to a clap variant that reuses
`JunitProcessCliArgs` and dispatches to
`mergify_ci::junit_process::run` after printing a
`DeprecationWarning: …` line to stderr (matches click's behavior
on first invocation).

This retires the last `ci` shim — `prepend_two` lost its only
remaining caller and goes with it. `stack` is now the only
shimmed top-level group left.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: Ic316f55c5d8a834cefa5d30ffbf5ebabec0a4122
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-process-shim-native-rust--6bd59de4 branch from cc3c840 to e5b9480 Compare May 27, 2026 10:15
@jd jd force-pushed the devs/jd/worktree-rust-port/promote-ci-junit-upload-shim-native-deprecated--c316f55c branch from a823367 to 7a63271 Compare May 27, 2026 10:15
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@jd jd temporarily deployed to func-tests-live May 27, 2026 10:15 — with GitHub Actions Inactive
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 27, 2026 10:15 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant