feat(ci): promote ci junit-upload from shim to native as a deprecated alias#1468
Conversation
This was referenced May 27, 2026
This was referenced May 27, 2026
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced May 27, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
8078737 to
ed7a74d
Compare
57bb83b to
bd85763
Compare
Member
Author
Revision history
|
bd85763 to
c994e93
Compare
ed7a74d to
6eeb3d9
Compare
c994e93 to
8460659
Compare
8460659 to
de0921a
Compare
6317d48 to
a353a93
Compare
a353a93 to
cc3c840
Compare
de0921a to
a823367
Compare
…ed alias `junit-upload` is the deprecated alias for `junit-process` — Python's `mergify_cli/ci/cli.py` declares it with click's `deprecated="Use \`junit-process\` instead"` decorator and delegates straight to the same `process_junit_files` body. The shim was still routing it through Python only because the orchestrator wasn't native yet; now that Phase C landed, we can collapse it down to a clap variant that reuses `JunitProcessCliArgs` and dispatches to `mergify_ci::junit_process::run` after printing a `DeprecationWarning: …` line to stderr (matches click's behavior on first invocation). This retires the last `ci` shim — `prepend_two` lost its only remaining caller and goes with it. `stack` is now the only shimmed top-level group left. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Change-Id: Ic316f55c5d8a834cefa5d30ffbf5ebabec0a4122
cc3c840 to
e5b9480
Compare
a823367 to
7a63271
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
junit-uploadis the deprecated alias forjunit-process—Python's
mergify_cli/ci/cli.pydeclares it with click'sdeprecated="Use \junit-process` instead"decorator and delegates straight to the sameprocess_junit_filesbody. The shim was still routing it through Python only because the orchestrator wasn't native yet; now that Phase C landed, we can collapse it down to a clap variant that reusesJunitProcessCliArgsand dispatches tomergify_ci::junit_process::runafter printing aDeprecationWarning: …` line to stderr (matches click's behavioron first invocation).
This retires the last
cishim —prepend_twolost its onlyremaining caller and goes with it.
stackis now the onlyshimmed top-level group left.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Depends-On: #1467