refactor(ci): swap uuid for getrandom in the GHA heredoc delimiter#1446
Conversation
This was referenced May 19, 2026
This was referenced May 19, 2026
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced May 19, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
sileht
previously approved these changes
May 20, 2026
jd
force-pushed
the
devs/jd/worktree-rust-port/swap-uuid-getrandom-gha-heredoc-delimiter--b6599e9b
branch
from
2cd6b4f to
5cd88c9
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/drop-indexmap-group-scope-returns-vec-k-v--7085cf29
branch
from
e31730b to
57559b2
Compare
Member
Author
Revision history
|
jd
force-pushed
the
devs/jd/worktree-rust-port/swap-uuid-getrandom-gha-heredoc-delimiter--b6599e9b
branch
from
5cd88c9 to
8468caf
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/drop-indexmap-group-scope-returns-vec-k-v--7085cf29
branch
from
1d374a9 to
a5fc066
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/swap-uuid-getrandom-gha-heredoc-delimiter--b6599e9b
branch
from
8468caf to
73811d4
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/swap-uuid-getrandom-gha-heredoc-delimiter--b6599e9b
branch
from
73811d4 to
d61afc0
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/drop-indexmap-group-scope-returns-vec-k-v--7085cf29
branch
from
a5fc066 to
a6e2beb
Compare
`ci queue-info::write_github_output` formatted a unique `ghadelimiter_<uuid-v4>` to guard against a metadata payload that happens to contain its own heredoc delimiter. The actual contract is "32 unpredictable hex chars", not "a UUID per RFC 4122" — the delimiter is never parsed by anyone, only matched as a string. Pull 16 random bytes straight from `getrandom::fill` and hex-encode them. Drops `uuid` from the direct deps (it stays unreferenced and disappears from `Cargo.lock`), with `getrandom` taking its place — which `uuid` was already pulling in transitively, so the net add is zero new code shipped to the binary. The local helper is six lines. Same blast radius for a maintainer-attack story, smaller surface to read. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Change-Id: Ib6599e9b6fca49281186b726a63e4641fa32596e
jd
force-pushed
the
devs/jd/worktree-rust-port/drop-indexmap-group-scope-returns-vec-k-v--7085cf29
branch
from
a6e2beb to
c99237a
Compare
jd
force-pushed
the
devs/jd/worktree-rust-port/swap-uuid-getrandom-gha-heredoc-delimiter--b6599e9b
branch
from
d61afc0 to
637e6a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci queue-info::write_github_outputformatted a uniqueghadelimiter_<uuid-v4>to guard against a metadata payload thathappens to contain its own heredoc delimiter. The actual contract
is "32 unpredictable hex chars", not "a UUID per RFC 4122" — the
delimiter is never parsed by anyone, only matched as a string.
Pull 16 random bytes straight from
getrandom::filland hex-encodethem. Drops
uuidfrom the direct deps (it stays unreferenced anddisappears from
Cargo.lock), withgetrandomtaking its place —which
uuidwas already pulling in transitively, so the net addis zero new code shipped to the binary.
The local helper is six lines. Same blast radius for a
maintainer-attack story, smaller surface to read.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Depends-On: #1445