Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Nov 15, 2024

@chunjiez, @stephenchengCloud, this PR helps to prepare for the next PRs (#145 is next) to fix running CI (tox, pre-commit)

Contents:

  • Fix the required code coverage by extending the unit tests to cover the missing lines.
  • Fix two spelling typos in the comments

@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11858778149

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.661%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.009%
Covered Lines: 2806
Relevant Lines: 3354

💛 - Coveralls

@bernhardkaindl

This comment was marked as outdated.

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl force-pushed the fix-github-ci-drop-old-versions-add-coverage branch from 0c94f63 to c30a358 Compare August 15, 2025 09:36
@bernhardkaindl bernhardkaindl requested review from chunjiez and stephenchengCloud and removed request for freddy77 August 15, 2025 09:36
@bernhardkaindl bernhardkaindl removed the request for review from GeraldEV August 15, 2025 09:37
@bernhardkaindl bernhardkaindl merged commit 116bc4f into master Aug 15, 2025
7 checks passed
@bernhardkaindl bernhardkaindl deleted the fix-github-ci-drop-old-versions-add-coverage branch September 26, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants