Skip to content

Conversation

@bernhardkaindl
Copy link
Contributor

@bernhardkaindl bernhardkaindl commented Nov 15, 2024

  • Fix pylint and 2nd half of the pyright warnings
  • pyright: Bump Python version to check to 3.11
  • pyright: Fix ErrorHandler taking Response | None
  • pyright: Skip warning on renamed arg: FTPAccessor.access(name->path)

- It has become impractical to use EOL versions like Python 3.6 in CI
- It has become counterproductive to use pyre CI, disable it for now.
- Move forward to run the unit tests with Python 3.11

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl changed the title [CI fixes PR #4] Fix pylint and 2nd half of the pyright warnings CI PR #4: Fix pylint and 2nd half of the pyright warnings Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Pull Request Test Coverage Report for Build 11859913232

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.009%) to 83.661%

Files with Coverage Reduction New Missed Lines %
xcp/accessor.py 1 89.1%
xcp/xmlunwrap.py 2 92.31%
xcp/cpiofile.py 3 75.26%
xcp/compat.py 6 78.57%
Totals Coverage Status
Change from base Build 9109272969: -0.009%
Covered Lines: 2806
Relevant Lines: 3354

💛 - Coveralls

Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Signed-off-by: Bernhard Kaindl <bernhard.kaindl@cloud.com>
@bernhardkaindl bernhardkaindl merged commit 702f21a into master Aug 15, 2025
7 checks passed
@bernhardkaindl bernhardkaindl deleted the fix-github-ci-pylint-and-2nd-pyright-warnings branch September 26, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants