Skip to content

Conversation

@colinmurphy
Copy link
Member

@colinmurphy colinmurphy commented Aug 18, 2025

…tored so setting the initial allowed post types fires after ACF registers post types.

Description

The current issue is that when we register the preview link, the allowed post types has already been set before ACF registers post types so therefore doesn't work.

The refactor sets the allowed post types after ACF is registering post types.

Related Issue

Fixes #374

Dependant PRs

Type of Change

  • ✅ Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactoring (no functional changes)
  • 📄 Example update (no functional changes)
  • 📝 Documentation update
  • 🔍 Performance improvement
  • 🧪 Test update

How Has This Been Tested?

Screenshots

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

…tored so setting the initial allowed post types fires after ACF registers post types.
@github-actions
Copy link

github-actions bot commented Aug 18, 2025

ℹ️ Download the latest hwp-previews plugin zip from this PR
(See the 'Artifacts' section at the bottom)

@colinmurphy colinmurphy marked this pull request as ready for review August 18, 2025 10:28
@colinmurphy colinmurphy requested a review from a team as a code owner August 18, 2025 10:28
@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2025

⚠️ No Changeset found

Latest commit: 3d8b4c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colinmurphy colinmurphy added this pull request to the merge queue Aug 18, 2025
Merged via the queue into main with commit de3e08d Aug 18, 2025
16 of 19 checks passed
@colinmurphy colinmurphy deleted the chore-fix-cpt-draft-preview branch August 18, 2025 10:43
@colinmurphy colinmurphy restored the chore-fix-cpt-draft-preview branch August 18, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ACF Custom Post Types config doesn't work

3 participants