Skip to content

Fix GPIO0 pin conflict detection when button is disabled #5259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+32 −2
Draft

Fix GPIO0 pin conflict detection when button is disabled #5259

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9066a34
Initial plan
Copilot Jan 1, 2026
ff56028
Fix GPIO0 button pin conflict detection in settings_leds.htm
Copilot Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions wled00/data/settings_leds.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,22 @@
//check for pin conflicts
if (LC.value!="" && LC.value!="-1") {
let p = d.rsvd.concat(d.um_p); // used pin array
d.Sf.querySelectorAll("select.pin").forEach((e)=>{if(e.value>-1)p.push(parseInt(e.value));}) // buttons, IR & relay
d.Sf.querySelectorAll("select.pin").forEach((e)=>{
if(e.value>-1) {
// Check if this is a button pin (name starts with "BT")
if (e.name.startsWith("BT")) {
// Get button type field (BEx where BTx is the pin field)
let btnTypeField = d.Sf["BE" + e.name.substring(2)];
// Only add to used pins if button is not disabled (type != 0)
if (btnTypeField && btnTypeField.value != "0") {
p.push(parseInt(e.value));
}
} else {
// For IR and Relay pins, add normally
p.push(parseInt(e.value));
}
}
}) // buttons, IR & relay
if (p.some((e)=>e==parseInt(LC.value))) {
alert(`Sorry, pins ${JSON.stringify(p)} can't be used.`);
LC.value="";
Expand Down Expand Up @@ -387,7 +402,22 @@
if (nm.search(/^L[0-4]/) == 0) // pin fields
if (LC.value!="" && LC.value!="-1") {
let p = d.rsvd.concat(d.um_p); // used pin array
d.Sf.querySelectorAll("select.pin").forEach((e)=>{if(e.value>-1)p.push(parseInt(e.value));}) // buttons, IR & relay
d.Sf.querySelectorAll("select.pin").forEach((e)=>{
if(e.value>-1) {
// Check if this is a button pin (name starts with "BT")
if (e.name.startsWith("BT")) {
// Get button type field (BEx where BTx is the pin field)
let btnTypeField = d.Sf["BE" + e.name.substring(2)];
// Only add to used pins if button is not disabled (type != 0)
if (btnTypeField && btnTypeField.value != "0") {
p.push(parseInt(e.value));
}
} else {
// For IR and Relay pins, add normally
p.push(parseInt(e.value));
}
}
}) // buttons, IR & relay
for (j=0; j<nList.length; j++) {
if (i==j) continue;
let n2 = nList[j].name.substring(0,2); // field name : /L./
Expand Down