Fix GPIO0 pin conflict detection when button is disabled #5259
+32
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ESP8266, GPIO0 defaults to button input but cannot be reassigned to LED output even when the button is disabled. The pin conflict checker unconditionally flags all button GPIO pins as in-use regardless of button state.
Changes
settings_leds.htmto check button type before marking pin as usedImplementation
Two instances of the conflict check were updated (in
pinsOK()andUI()functions):Users can now set button type to "Disabled" or GPIO to "-1" to free the pin for LED use.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.