Skip to content

fix(rolldown): remove hooks filter #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webfansplz merged 1 commit into from
Feb 18, 2026
Merged

fix(rolldown): remove hooks filter #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/rolldown/src/node/rolldown/events-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ export type RolldownEvent = Event & {

type ModuleBuildHookEvents = (Exclude<Event, 'StringRef'> & (HookResolveIdCallStart | HookResolveIdCallEnd | HookLoadCallStart | HookLoadCallEnd | HookTransformCallStart | HookTransformCallEnd)) & { event_id: string }

const DURATION_THRESHOLD = 10
const MODULE_BUILD_START_HOOKS = ['HookResolveIdCallStart', 'HookLoadCallStart', 'HookTransformCallStart']
const MODULE_BUILD_END_HOOKS = ['HookResolveIdCallEnd', 'HookLoadCallEnd', 'HookTransformCallEnd']

Expand Down Expand Up @@ -77,9 +76,6 @@ export class RolldownEventsManager {
})
}
else if (event.action === 'HookLoadCallEnd') {
if (!event.content && info.duration < DURATION_THRESHOLD) {
return
}
module_build_metrics.loads.push({
...info,
type: 'load',
Expand All @@ -95,10 +91,6 @@ export class RolldownEventsManager {
else if (event.action === 'HookTransformCallEnd') {
const _start = start as HookTransformCallStart
const _end = event as HookTransformCallEnd
const no_changes = _start.content === _end.content
if (no_changes && info.duration < DURATION_THRESHOLD) {
return
}

module_build_metrics.transforms.push({
...info,
Expand Down
Loading