Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/components/__tests__/api-provider.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,26 @@ test('waits for externally installed importLibrary before marking API as loaded'
expect(settingsInstance.fetchAppCheckToken).toBe(mockFetchToken);
});

test('primes js-api-loader when importLibrary is installed externally', async () => {
google.maps.importLibrary = asGoogleMapsImportLibrary(async libraryName => {
await importLibraryPromise;

if (libraryName === 'core') {
return {} as google.maps.CoreLibrary;
}

return {} as google.maps.MapsLibrary;
});

render(<APIProvider apiKey={'apikey'}></APIProvider>);

await act(async () => {
triggerMapsApiLoaded();
});

await waitFor(() => expect(setOptionsSpy).toHaveBeenCalled());
});

describe('internalUsageAttributionIds', () => {
test('provides default attribution IDs in context', () => {
render(
Expand Down
55 changes: 31 additions & 24 deletions src/components/api-provider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -291,30 +291,6 @@ function useGoogleMapsApiLoader(props: APIProviderProps) {

const librariesToLoad = ['core', 'maps', ...libraries];

// If the google.maps namespace is already available, the API has been loaded externally.
if (window.google?.maps?.importLibrary as unknown) {
await Promise.all(
librariesToLoad.map(name => importLibraryCallback(name))
);
if (!serializedApiParams) {
updateLoadingStatus(APILoadingStatus.LOADED);
}
if (onLoad) onLoad();
return;
}

// Abort if the API is already loading or has been loaded.
if (
loadingStatus === APILoadingStatus.LOADING ||
loadingStatus === APILoadingStatus.LOADED
) {
if (loadingStatus === APILoadingStatus.LOADED && onLoad) onLoad();
return;
}

serializedApiParams = currentSerializedParams;
updateLoadingStatus(APILoadingStatus.LOADING);

const options: APIOptions = Object.fromEntries(
Object.entries({
key: apiKey,
Expand All @@ -338,6 +314,37 @@ function useGoogleMapsApiLoader(props: APIProviderProps) {
options.solutionChannel = solutionChannel;
}

// If the google.maps namespace is already available, the API has been loaded externally.
if (window.google?.maps?.importLibrary as unknown) {
const shouldUpdateLoadingStatus = !serializedApiParams;

if (shouldUpdateLoadingStatus) {
serializedApiParams = currentSerializedParams;
setOptions(options);
}

await Promise.all(
librariesToLoad.map(name => importLibraryCallback(name))
);
if (shouldUpdateLoadingStatus) {
updateLoadingStatus(APILoadingStatus.LOADED);
}
if (onLoad) onLoad();
return;
}

// Abort if the API is already loading or has been loaded.
if (
loadingStatus === APILoadingStatus.LOADING ||
loadingStatus === APILoadingStatus.LOADED
) {
if (loadingStatus === APILoadingStatus.LOADED && onLoad) onLoad();
return;
}

serializedApiParams = currentSerializedParams;
updateLoadingStatus(APILoadingStatus.LOADING);

// this will actually trigger loading the maps API
setOptions(options);

Expand Down