fix: handle externally-loaded importLibrary in loader#1002
Open
mrMetalWood wants to merge 1 commit into
Open
Conversation
usefulthink
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a warning from @googlemaps/js-api-loader when the Google Maps API was already loaded before APIProvider mounted.
Previously, APIProvider detected an existing google.maps.importLibrary and skipped its own loader setup. That meant setOptions() was never called, but the provider still used the loader’s importLibrary() wrapper, causing a dev warning about missing options.
This change makes APIProvider call setOptions() once before using the loader wrapper, even when the Maps API was loaded externally. The existing external-loader behavior is preserved.
Also adds a regression test for the externally loaded API case.
fixes #972