-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
DRAFT for CI: Add RootFS and SMACK support for id, ls, mkdir, mkfifo, mknod #9866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e887ac to
b4c10c1
Compare
CodSpeed Performance ReportMerging #9866 will degrade performance by 5.5%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
Please split it into several PR. |
b4c10c1 to
1dbe628
Compare
|
This is just a working draft for now, mostly related to the CI stuff with a bunch of debugging info, will split it and clean it up a ton if it ends up being successful |
3b0e264 to
d685757
Compare
|
OK, then, please don't open the PR. We have too many and it makes our life much harder to keep track of them |
|
What's the best way for me to run the CI stuff, thats all I'm testing now?
…On Fri, Dec 26, 2025 at 10:09 AM Sylvestre Ledru ***@***.***> wrote:
*sylvestre* left a comment (uutils/coreutils#9866)
<#9866 (comment)>
OK, then, please don't open the PR. We have too many and it makes our life
much harder to keep track of them
—
Reply to this email directly, view it on GitHub
<#9866 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGM5PJTS2CVQYIFD6VKVMF34DV2UPAVCNFSM6AAAAACQCJ5G7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJTGE4DSNZZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
d685757 to
81f7f61
Compare
bd3f210 to
a51c697
Compare
a51c697 to
b7809ea
Compare
Quite a PITA to get QEMU to work but by making a base arch linux distribution and only copying over the binaries that are referenced, it makes it that it can run in 3 minutes |
If you push to main in your fork, it should start the ci You can update the github files to have the Ci run on other branches too
|
Any chance to reduce time for SELinux too? |
|
GNU testsuite comparison: |
|
I think the main issue in the SELinux example is that the program is compiled within the emulator instead of compiled outside the emulator and copied over. You can definitely make the SELinux distribution smaller by only compiling a subset of the binaries that are used |
|
About subset, #9567 was previously working well and saved 5min +. But broken now... |
|
To break this down I think the three stages are first adding the fix for ls: #9868 since that utility is actually used to determine whether the environment supports smack. Then I can follow up with a cleaned up and minimal script for running the smack tests which will be able to show the tests moving from skip to fail. Then the last step is actually adding the code changes for fixing the other utilities. The one tricky part is that we do not have an environment currently where we can run our regular rust integration tests that supports smack, I would like to build rust smack integration tests in the long run but they would require building out the CI support. |
|
Any Linux distribution supporting SELinux and smack at 1 kernel? 3 VM for GNU tests is too large... |
|
sorry, it needs to be rebased |
|
This is the last PR to fully implement these changes, #9910 after that one is in I can follow up with the RootFS tests |
This Draft PR is to provide a reference for the other PR's that will make up the steps to enable SMACK and RootFS support and GNU testing in the CI.
This PR needs to be broken down into three separate PR's but hoping to keep this one around to show how when all of the proposed changes are combined it allows you to run and pass the SMACK GNU tests.