Skip to content

Conversation

@ChrisDryden
Copy link
Collaborator

@ChrisDryden ChrisDryden commented Dec 28, 2025

This is the second step of enabling SMACK support in uutils as outlined in the prototype #9866 . This PR creates a QEMU environment using Kali Linux that has SMACK enabled and creates a minimal environment to run the GNU tests in. This change also includes all of the GitHub workflows related to reading the logs associated with the SMACK integration tests and adding it to the GNU analyzer workflow that can comment and keep track of when tests begin to pass or fail.

@ChrisDryden ChrisDryden marked this pull request as ready for review December 28, 2025 14:46
@github-actions
Copy link

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@sylvestre
Copy link
Contributor

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

excellent!

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tty/tty-eof is no longer failing!
Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@sylvestre sylvestre merged commit bea05bb into uutils:main Dec 28, 2025
129 of 130 checks passed
@oech3
Copy link
Contributor

oech3 commented Dec 29, 2025

Your SMACK runner looks fast. Any idea about #9600 ?
CachyOS(Arch fork) has libselinux package.

@ChrisDryden
Copy link
Collaborator Author

I don't think it will materialize the same time savings because it's compiling the binaries outside of the emulator and the selinux feature flag requires compiling on a selinux system. If that's not the case then it would definitely speed things up

@oech3
Copy link
Contributor

oech3 commented Dec 29, 2025

We don't need setenforce to build. Needs headers only.

@ChrisDryden
Copy link
Collaborator Author

I will try it out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants