Skip to content

Add date-based query helpers for createdAt and updatedAt#653

Merged
abnegate merged 2 commits intomainfrom
add-date-query-wrappers
Aug 7, 2025
Merged

Add date-based query helpers for createdAt and updatedAt#653
abnegate merged 2 commits intomainfrom
add-date-query-wrappers

Conversation

@abnegate
Copy link
Member

@abnegate abnegate commented Aug 7, 2025

Summary by CodeRabbit

  • New Features

    • Added support for filtering documents based on creation and update timestamps with new date-based query options.
  • Tests

    • Expanded test coverage to verify correct behavior of the new date-based query filters, including both end-to-end and unit tests.

Co-authored-by: jakeb994 <jakeb994@gmail.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Walkthrough

Four new static methods were added to the Query class to support filtering by document creation and update timestamps. Corresponding unit and end-to-end tests were introduced to verify these methods, ensuring correct query construction and integration with the database's find operation.

Changes

Cohort / File(s) Change Summary
Query Date Helper Methods
src/Database/Query.php
Added four static methods: createdBefore, createdAfter, updatedBefore, and updatedAfter to enable timestamp-based filtering for queries.
End-to-End Tests for Date Queries
tests/e2e/Adapter/Scopes/DocumentTests.php
Introduced five new test methods to verify database find operations using the new date-based query helpers, checking both future and past date boundaries.
Unit Tests for Query Helpers
tests/unit/QueryTest.php
Expanded the test suite to cover the creation and parsing of the new date-based query helper methods, ensuring correct method, attribute, and value handling.

Sequence Diagram(s)

sequenceDiagram
    participant TestSuite
    participant Query
    participant Database

    TestSuite->>Query: createdBefore(isoDate)
    Query-->>TestSuite: Query instance for $createdAt < isoDate

    TestSuite->>Database: find(collection, [Query])
    Database-->>TestSuite: Filtered documents

    TestSuite->>Query: updatedAfter(isoDate)
    Query-->>TestSuite: Query instance for $updatedAt > isoDate

    TestSuite->>Database: find(collection, [Query])
    Database-->>TestSuite: Filtered documents
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • abnegate

Poem

In the warren where queries hop and play,
New helpers leap to filter by date and day.
With tests to check each timely bound,
Now rabbits find what’s lost or found.
Timestamps guide us, swift and bright—
Code and carrots, both done right! 🥕


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c3e29c5 and c7975f9.

📒 Files selected for processing (1)
  • src/Database/Query.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/Database/Query.php
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-date-query-wrappers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- Updated all four date query methods to use $value parameter
- Maintains consistency with other Query methods
- Any date value is valid as dates are stored as ISO 8601 in DB
@abnegate abnegate merged commit a8ab3a7 into main Aug 7, 2025
15 checks passed
@abnegate abnegate deleted the add-date-query-wrappers branch August 7, 2025 09:30
@coderabbitai coderabbitai bot mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants