Skip to content

Add time between queries#684

Merged
abnegate merged 1 commit intomainfrom
feat-between
Sep 4, 2025
Merged

Add time between queries#684
abnegate merged 1 commit intomainfrom
feat-between

Conversation

@abnegate
Copy link
Member

@abnegate abnegate commented Sep 4, 2025

Summary by CodeRabbit

  • New Features

    • Added built-in date-range filters for creation and update timestamps, allowing easier queries for items within specific time windows.
  • Tests

    • Introduced unit and end-to-end tests covering wide, narrow, and boundary date ranges, plus round-trip parsing validation to ensure consistent, reliable behavior of the new date-range filters.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds two static helper methods to Query for created/updated timestamp ranges and introduces unit and end-to-end tests validating their behavior and parsing.

Changes

Cohort / File(s) Summary of Changes
Query helpers
src/Database/Query.php
Added public static createdBetween(string $start, string $end): self and public static updatedBetween(string $start, string $end): self, delegating to between('$createdAt', ...) and between('$updatedAt', ...).
E2E tests for date range wrappers
tests/e2e/Adapter/Scopes/DocumentTests.php
Added tests testFindCreatedBetween and testFindUpdatedBetween asserting result presence over wide ranges, zero results on single-day windows, and non-decreasing counts with broader ranges.
Unit tests for helpers and parsing
tests/unit/QueryTest.php
Added tests covering createdBetween and updatedBetween construction and round-trip parsing via toString() and Query::parse().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • fogelito

Poem

A nibble of time between start and end,
I hop through dates that queries send.
Created? Updated? I mark the scene—
Two fresh trails in fields unseen.
Tests burrow deep, all paths align,
Carrot-shaped ranges returning fine. 🥕🐇


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between fcd166b and 35b7744.

📒 Files selected for processing (3)
  • src/Database/Query.php (1 hunks)
  • tests/e2e/Adapter/Scopes/DocumentTests.php (1 hunks)
  • tests/unit/QueryTest.php (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-between

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abnegate abnegate marked this pull request as ready for review September 4, 2025 11:44
@abnegate abnegate merged commit d32bd61 into main Sep 4, 2025
14 of 15 checks passed
@abnegate abnegate deleted the feat-between branch September 4, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant