Skip to content

Harden BdIntegral boundary label resolution across mesh label layouts #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Harden BdIntegral boundary label resolution across mesh label layouts #73

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e22b600
Initial plan
Copilot Mar 6, 2026
51a5a35
BdIntegral: fallback to UW_Boundaries label with collective missing-l…
Copilot Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/underworld3/cython/petsc_maths.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,18 @@ class BdIntegral:
cdef PetscInt num_vals = 1

c_label = mesh.dm.getLabel(self.boundary)
if c_label is None:
# Some meshes keep boundary strata only on the consolidated label.
# Fall back to UW_Boundaries and select this boundary via label_val.
c_label = mesh.dm.getLabel("UW_Boundaries")
if underworld3.mpi.comm.allreduce(1 if c_label else 0) == 0:
mesh_name = getattr(mesh, "name", "<unnamed mesh>")
raise ValueError(
f"Boundary '{self.boundary}' was requested on mesh '{mesh_name}', "
f"but neither a DM label named '{self.boundary}' nor the "
"'UW_Boundaries' label "
"was found on this mesh."
)

# Output value
cdef PetscScalar result = 0.0
Expand Down