Skip to content

feat(duckdb): do not issue CREATE unsupported iceberg property warning #7396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 2 commits into from
Mar 26, 2026
Merged

feat(duckdb): do not issue CREATE unsupported iceberg property warning #7396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b41694
do not issue duckdb unsupported iceberg property warning
treysp Mar 25, 2026
2d18964
Simplify
georgesittas Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlglot/generators/duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1591,6 +1591,7 @@ class DuckDBGenerator(generator.Generator):
exp.Getbit: getbit_sql,
exp.GroupConcat: lambda self, e: groupconcat_sql(self, e, within_group=False),
exp.Explode: rename_func("UNNEST"),
exp.IcebergProperty: lambda *_: "",
Copy link
Copy Markdown
Collaborator

@georgesittas georgesittas Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified this quite a bit after all.

exp.IntDiv: lambda self, e: self.binary(e, "//"),
exp.IsInf: rename_func("ISINF"),
exp.IsNan: rename_func("ISNAN"),
Expand Down Expand Up @@ -1836,6 +1837,7 @@ class DuckDBGenerator(generator.Generator):
exp.TemporaryProperty: exp.Properties.Location.POST_CREATE,
exp.ReturnsProperty: exp.Properties.Location.POST_ALIAS,
exp.SequenceProperties: exp.Properties.Location.POST_EXPRESSION,
exp.IcebergProperty: exp.Properties.Location.POST_CREATE,
}

IGNORE_RESPECT_NULLS_WINDOW_FUNCTIONS: t.ClassVar = _IGNORE_RESPECT_NULLS_WINDOW_FUNCTIONS
Expand Down
19 changes: 19 additions & 0 deletions tests/dialects/test_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
from unittest import mock

from sqlglot import ParseError, UnsupportedError, exp, parse_one
from sqlglot.generator import logger as generator_logger
from sqlglot.helper import logger as helper_logger
Expand Down Expand Up @@ -2155,6 +2157,23 @@ def test_parameter_token(self):
write={"bigquery": "SELECT @foo", "duckdb": "SELECT $foo"},
)

def test_iceberg_property_no_warning(self):
expression = parse_one("CREATE ICEBERG TABLE t (a INT)", dialect="snowflake")

with mock.patch("sqlglot.generator.logger.warning") as warning:
self.assertEqual(expression.sql(dialect="duckdb"), "CREATE TABLE t (a INT)")
warning.assert_not_called()

def test_non_iceberg_property_still_warns(self):
expression = parse_one("CREATE TRANSIENT TABLE t (a INT)", dialect="snowflake")

with self.assertLogs(generator_logger) as cm:
self.assertEqual(expression.sql(dialect="duckdb"), "CREATE TABLE t (a INT)")

self.assertEqual(
str(cm.output[0]), "WARNING:sqlglot:Unsupported property transientproperty"
)

def test_ignore_nulls(self):
# Note that DuckDB differentiates window functions (e.g. LEAD, LAG) from aggregate functions (e.g. SUM)
from sqlglot.dialects.duckdb import DuckDB
Expand Down
Loading