feat(duckdb): do not issue CREATE unsupported iceberg property warning#7396
Merged
georgesittas merged 2 commits intomainfrom Mar 26, 2026
Merged
feat(duckdb): do not issue CREATE unsupported iceberg property warning#7396georgesittas merged 2 commits intomainfrom
georgesittas merged 2 commits intomainfrom
Conversation
treysp
changed the title
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 113551 total, 111862 passed (pass rate: 98.5%), sqlglot version: sqlglot:trey/duck-iceberg-nowarn: 98730 total, 98730 passed (pass rate: 100.0%), sqlglot version: Transitions: ✅ 1 test(s) passed |
themisvaltinos
approved these changes
Mar 26, 2026
georgesittas
approved these changes
Mar 26, 2026
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
A couple of suggestions, LGTM otherwise. I can take this to the finish line.
georgesittas
force-pushed
the
trey/duck-iceberg-nowarn
branch
from
5f6c975 to
2d18964
Compare
| exp.Getbit: getbit_sql, | ||
| exp.GroupConcat: lambda self, e: groupconcat_sql(self, e, within_group=False), | ||
| exp.Explode: rename_func("UNNEST"), | ||
| exp.IcebergProperty: lambda *_: "", |
Collaborator
There was a problem hiding this comment.
Simplified this quite a bit after all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because DuckDB
CREATE TABLEdoes not supportIcebergProperty, it warns when transpiling a snowflakeCREATE ICEBERG TABLEstatement. This PR prevents that warning.Context
Creating an Iceberg table in snowflake requires
CREATE ICEBERG TABLE. When parsed, theIcebergPropertyis attached to the AST.DuckDB's
CREATE TABLEstatement is backend-agnostic and does not reference iceberg. Therefore, the iceberg property carries no semantic information and can safely be ignored.