Skip to content

DOC-3150: Context forms used to disappear if their input were disabled in the onSetup API #3644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinavgandham merged 2 commits into from
Mar 4, 2025
Merged

DOC-3150: Context forms used to disappear if their input were disabled in the onSetup API #3644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968a5a2
DOC-3150: Context forms used to disappear if their input were disable…
abhinavgandham Mar 4, 2025
8a41751
Update modules/ROOT/pages/7.7.1-release-notes.adoc
abhinavgandham Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions modules/ROOT/pages/7.7.1-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ In {productname} {release-version}, an issue was identified where skin content C

This issue has been resolved in {productname} {release-version}. The bundling process now correctly incorporates CSS styles into the generated JavaScript resources, preventing truncation and ensuring consistent styling across the editor UI.

=== Context forms used to disappear if their input was disabled in the `onSetup` API.
// #TINY-11890

Previously, an issue was identified where disabling a context form's input in the `onSetup` function caused the form to disappear due to focus being set on a non-focusable element.

In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus remains intact, preventing the context form from disappearing.
Copy link
Contributor

@lorenzo-pomili lorenzo-pomili Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the focus remains intact

I'm not entirely sure about this sentence (but I'm not a native English speaker so I could be completely wrong 😅 ), maybe I would say that the focus now is moved on a valid element, meaning a focusable element, saying that the focus remains intact sounds to me like it doesn't move at all, but I repeat I'm not a native English speaker so I could misunderstand the nuance of this sentence.

For the rest good job 👍

Copy link
Contributor

@kemister85 kemister85 Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, if we want to update this before we ship it...

Suggested change
In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus remains intact, preventing the context form from disappearing.
In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus is properly redirected, preventing the context form from disappearing.


For more information on the `onSetup` function and context forms, see xref:contextform.adoc[Context Forms]

[[known-issues]]
== Known issues
Expand Down