DOC-3150: Context forms used to disappear if their input were disabled in the onSetup API#3644
Merged
abhinavgandham merged 2 commits intofeature/7.7.1/DOC-3150from Mar 4, 2025
Conversation
abhinavgandham
requested review from
a team,
kemister85 and
soritaheng
as code owners
abhinavgandham
requested review from
EkimChau,
MitchC1999 and
lorenzo-pomili
and removed request for
a team
kemister85
reviewed
Mar 4, 2025
kemister85
approved these changes
Mar 4, 2025
Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
lorenzo-pomili
approved these changes
Mar 4, 2025
|
|
||
| Previously, an issue was identified where disabling a context form's input in the `onSetup` function caused the form to disappear due to focus being set on a non-focusable element. | ||
|
|
||
| In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus remains intact, preventing the context form from disappearing. |
Contributor
There was a problem hiding this comment.
the focus remains intact
I'm not entirely sure about this sentence (but I'm not a native English speaker so I could be completely wrong 😅 ), maybe I would say that the focus now is moved on a valid element, meaning a focusable element, saying that the focus remains intact sounds to me like it doesn't move at all, but I repeat I'm not a native English speaker so I could misunderstand the nuance of this sentence.
For the rest good job 👍
Contributor
There was a problem hiding this comment.
Just a suggestion, if we want to update this before we ship it...
Suggested change
| In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus remains intact, preventing the context form from disappearing. | |
| In {productname} {release-version}, this issue has been resolved by ensuring that the fallback focus is directed to a focusable element. As a result, even when the input is disabled, the focus is properly redirected, preventing the context form from disappearing. |
abhinavgandham
added
the
upcoming release
kemister85
added a commit
that referenced
this pull request
Mar 5, 2025
#3637) * DOC-3150: TinyMCE 7.7.1 Release Documentation and Community Changelog. * DOC-3150: Skin UI content CSS was truncated when bundling, causing CSS styles to be missing. (#3638) * DOC-3150: Skin UI content CSS was truncated when bundling, causing CSS styles to be missing. * Update modules/ROOT/pages/7.7.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * Update modules/ROOT/pages/7.7.1-release-notes.adoc * Updated changelog with 7.7.1 entries. * DOC-3150: Context forms used to disappear if their input were disabled in the `onSetup` API (#3644) * DOC-3150: Update release notes for 7.7.1 to include security fixes and accompanying changes. * DOC-3150: update nav.adoc file to include server-side changes. * Update modules/ROOT/pages/7.7.1-release-notes.adoc * Removed headings that are not needed. --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
kemister85
added a commit
that referenced
this pull request
Mar 5, 2025
* DOC-3149: TinyMCE 7.7.1 Release Documentation. * DOC-3150: TinyMCE 7.7.1 Release Documentation and Community Changelog. (#3637) * DOC-3150: TinyMCE 7.7.1 Release Documentation and Community Changelog. * DOC-3150: Skin UI content CSS was truncated when bundling, causing CSS styles to be missing. (#3638) * DOC-3150: Skin UI content CSS was truncated when bundling, causing CSS styles to be missing. * Update modules/ROOT/pages/7.7.1-release-notes.adoc Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> * Update modules/ROOT/pages/7.7.1-release-notes.adoc * Updated changelog with 7.7.1 entries. * DOC-3150: Context forms used to disappear if their input were disabled in the `onSetup` API (#3644) * DOC-3150: Update release notes for 7.7.1 to include security fixes and accompanying changes. * DOC-3150: update nav.adoc file to include server-side changes. * Update modules/ROOT/pages/7.7.1-release-notes.adoc * Removed headings that are not needed. --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com> --------- Co-authored-by: Karl Kemister-Sheppard <karlkemistersheppard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3150
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: