Fix get_index_url to avoid proxy by default + refactor get_artifact_url #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with get_artifact_url. Typically if you're building a url rather than actually fetching something, then it's because the downloading will happen in a downstream task, where the proxy might not be available, or might have a different url. So defaulting to not using it makes the most sense.
get_root_url already normalizes the url, so no need for the if/else here.
ahal
force-pushed
the
ahal/push-rsmvorrqvqry
branch
from
0a4fecf to
327e97b
Compare
jcristau
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it inline with
get_artifact_url.