run-task: don't parse git clean's error output
#833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
reviewed
Oct 23, 2025
bhearsum
approved these changes
Oct 23, 2025
jcristau
force-pushed
the
git-clean-stderr
branch
from
a2a375b to
4cc41f8
Compare
Contributor
Author
|
I've split out the cleanup part in its own commit with its own commit message/explanation. Thanks for the comments here. |
bhearsum
approved these changes
Oct 23, 2025
jcristau
force-pushed
the
git-clean-stderr
branch
from
4cc41f8 to
3a6c12f
Compare
jcristau
force-pushed
the
git-clean-stderr
branch
from
3a6c12f to
09471ef
Compare
bhearsum
approved these changes
Oct 23, 2025
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
There's a lint issue to fix but this lgtm otherwise
We were sending stdout and stderr into the same stream and then attempting to parse as if it were a list of paths. That doesn't go awesomely well when there's actual error output mixed in there.
jcristau
force-pushed
the
git-clean-stderr
branch
2 times, most recently
from
066547d to
919681d
Compare
This was copied from `run_command` in 8d7d8b1, but some stuff doesn't make sense here: - we don't stream the output to our log so we don't need to disable buffering or go through a TextIOWrapper - we don't want to pass our stdin to the command Instead we can use subprocess.run and let it capture stdout and check the returncode.
jcristau
force-pushed
the
git-clean-stderr
branch
from
919681d to
6f95029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were sending stdout and stderr into the same stream and then attempting to parse as if it were a list of paths. That doesn't go awesomely well when there's actual error output mixed in there.