Skip to content

Commit a2a375b

Browse files
committed
run-task: don't parse git clean's error output
We were sending stdout and stderr into the same stream and then attempting to parse as if it were a list of paths. That doesn't go awesomely well when there's actual error output mixed in there.
1 parent 234e8e4 commit a2a375b

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/taskgraph/run-task/run-task

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -599,13 +599,8 @@ def _clean_git_checkout(destination_path):
599599
print_line(b"vcs", b"executing %r\n" % args)
600600
p = subprocess.Popen(
601601
args,
602-
# Disable buffering because we want to receive output
603-
# as it is generated so timestamps in logs are
604-
# accurate.
605-
bufsize=0,
606602
stdout=subprocess.PIPE,
607-
stderr=subprocess.STDOUT,
608-
stdin=sys.stdin.fileno(),
603+
stdin=subprocess.DEVNULL,
609604
cwd=destination_path,
610605
env=os.environ,
611606
)

0 commit comments

Comments
 (0)