Skip to content

Actually retag images when a tag is passed to taskgraph load-image #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eijebong merged 1 commit into from
Jun 27, 2025
Merged

Actually retag images when a tag is passed to taskgraph load-image #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/taskgraph/docker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,21 @@ def download_and_modify_image():
# Open stream reader for the member
reader = tarin.extractfile(member)

# If the member is `manifest.json` and we're retagging the image,
# override RepoTags.
if member.name == "manifest.json" and imageName:
manifest = json.loads(reader.read()) # type: ignore
reader.close() # type: ignore

if len(manifest) > 1:
raise Exception("file contains more than one manifest")

manifest[0]["RepoTags"] = [f"{imageName}:{imageTag}"]

data = json.dumps(manifest)
reader = BytesIO(data.encode("utf-8"))
member.size = len(data)

# If member is `repositories`, we parse and possibly rewrite the
# image tags.
if member.name == "repositories":
Expand Down
Loading